DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] hash: use x86 common flag for jhash
@ 2020-10-22  7:59 David Marchand
  2020-10-22  8:22 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2020-10-22  7:59 UTC (permalink / raw)
  To: dev; +Cc: Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara

jhash has been forgotten when factorising the x86 arch check.

Fixes: dbf17d44f375 ("hash: use common x86 flag")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_hash/rte_jhash.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h
index 7a1eeff74e..f2446f081e 100644
--- a/lib/librte_hash/rte_jhash.h
+++ b/lib/librte_hash/rte_jhash.h
@@ -91,7 +91,7 @@ __rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc,
 	 * Check key alignment. For x86 architecture, first case is always optimal
 	 * If check_align is not set, first case will be used
 	 */
-#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32)
+#if defined(RTE_ARCH_X86)
 	const uint32_t *k = (const uint32_t *)key;
 	const uint32_t s = 0;
 #else
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] hash: use x86 common flag for jhash
  2020-10-22  7:59 [dpdk-dev] [PATCH] hash: use x86 common flag for jhash David Marchand
@ 2020-10-22  8:22 ` Bruce Richardson
  2020-10-22 20:08   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-10-22  8:22 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Yipeng Wang, Sameh Gobriel, Pablo de Lara

On Thu, Oct 22, 2020 at 09:59:59AM +0200, David Marchand wrote:
> jhash has been forgotten when factorising the x86 arch check.
> 
> Fixes: dbf17d44f375 ("hash: use common x86 flag")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  lib/librte_hash/rte_jhash.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h
> index 7a1eeff74e..f2446f081e 100644
> --- a/lib/librte_hash/rte_jhash.h
> +++ b/lib/librte_hash/rte_jhash.h
> @@ -91,7 +91,7 @@ __rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc,
>  	 * Check key alignment. For x86 architecture, first case is always optimal
>  	 * If check_align is not set, first case will be used
>  	 */
> -#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32)
> +#if defined(RTE_ARCH_X86)
>  	const uint32_t *k = (const uint32_t *)key;

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] hash: use x86 common flag for jhash
  2020-10-22  8:22 ` Bruce Richardson
@ 2020-10-22 20:08   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-10-22 20:08 UTC (permalink / raw)
  To: dev; +Cc: Yipeng Wang, Sameh Gobriel, Pablo de Lara, Bruce Richardson

On Thu, Oct 22, 2020 at 10:23 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Thu, Oct 22, 2020 at 09:59:59AM +0200, David Marchand wrote:
> > jhash has been forgotten when factorising the x86 arch check.
> >
> > Fixes: dbf17d44f375 ("hash: use common x86 flag")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-22 20:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22  7:59 [dpdk-dev] [PATCH] hash: use x86 common flag for jhash David Marchand
2020-10-22  8:22 ` Bruce Richardson
2020-10-22 20:08   ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git