From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Luca Boccassi <bluca@debian.org>,
Kevin Traynor <ktraynor@redhat.com>
Cc: SteveX Yang <stevex.yang@intel.com>, dev <dev@dpdk.org>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ciara Power <ciara.power@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded
Date: Mon, 14 Sep 2020 10:46:54 +0200 [thread overview]
Message-ID: <CAJFAV8z7AK0WT2GrbHX7=Ab4-jOnoE4JC_PYYjJSsB1nH4R94A@mail.gmail.com> (raw)
In-Reply-To: <20200911144539.GC732@bricha3-MOBL.ger.corp.intel.com>
On Fri, Sep 11, 2020 at 4:45 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> I don't particularly like keeping the old defines around, since they are
> inconsistent in naming, but since we didn't announce a deprecation of the
> old values perhaps we should add them in.
I don't like keeping those either, but we did not announce it and
those defines are part of the API (people relying on them to control
their own code).
So my vote is on putting a deprecation for 21.02... cleaning the code
so that it uses $meson_token (example RTE_LIBRTE_BOND_PMD) and adding
a compat macro (meson -> make) as you suggested.
For the backports... the stable maintainers will be the one impacted :-).
--
David Marchand
next prev parent reply other threads:[~2020-09-14 8:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 1:55 [dpdk-dev] [PATCH v1] " SteveX Yang
2020-09-10 9:16 ` Bruce Richardson
2020-09-10 11:12 ` Bruce Richardson
2020-09-11 5:58 ` [dpdk-dev] [PATCH v2] " SteveX Yang
2020-09-11 7:23 ` Yang, Qiming
2020-09-11 7:43 ` David Marchand
2020-09-11 8:36 ` Bruce Richardson
[not found] ` <DM6PR11MB436292727A47B651746AB246F9240@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-11 9:40 ` Bruce Richardson
[not found] ` <DM6PR11MB4362CF8D42FE275B79B84978F9230@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-14 8:33 ` Bruce Richardson
2020-09-14 16:24 ` Bruce Richardson
2020-09-11 11:32 ` David Marchand
2020-09-11 14:45 ` Bruce Richardson
2020-09-14 8:46 ` David Marchand [this message]
2020-09-16 16:46 ` Richardson, Bruce
2020-09-15 2:24 ` [dpdk-dev] [PATCH v3] " SteveX Yang
2020-09-30 16:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z7AK0WT2GrbHX7=Ab4-jOnoE4JC_PYYjJSsB1nH4R94A@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).