DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available
@ 2021-01-14  7:13 Hemant Agrawal
  2021-01-14 13:44 ` David Marchand
  0 siblings, 1 reply; 6+ messages in thread
From: Hemant Agrawal @ 2021-01-14  7:13 UTC (permalink / raw)
  To: dev; +Cc: Hemant Agrawal

Secondary process may not have all the tailq available for
mapping, so better to ignore the error.

e.g. if the primary process is linked with N libs
and secondary process is linked with less number of libs.

dpdk-procinfo results into following error:
EAL: Cannot initialize tailq: VMBUS_RESOURCE_LIST

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 lib/librte_eal/common/eal_common_tailqs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_tailqs.c b/lib/librte_eal/common/eal_common_tailqs.c
index ead06897b8..55bfc70db4 100644
--- a/lib/librte_eal/common/eal_common_tailqs.c
+++ b/lib/librte_eal/common/eal_common_tailqs.c
@@ -155,7 +155,8 @@ rte_eal_tailqs_init(void)
 		/* second part of register job for "early" tailqs, see
 		 * rte_eal_tailq_register and EAL_REGISTER_TAILQ */
 		rte_eal_tailq_update(t);
-		if (t->head == NULL) {
+		if (t->head == NULL &&
+			rte_eal_process_type() == RTE_PROC_PRIMARY) {
 			RTE_LOG(ERR, EAL,
 				"Cannot initialize tailq: %s\n", t->name);
 			/* TAILQ_REMOVE not needed, error is already fatal */
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available
  2021-01-14  7:13 [dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available Hemant Agrawal
@ 2021-01-14 13:44 ` David Marchand
  2021-01-18  5:55   ` Hemant Agrawal
  0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2021-01-14 13:44 UTC (permalink / raw)
  To: Hemant Agrawal; +Cc: dev, Burakov, Anatoly, Bruce Richardson

On Thu, Jan 14, 2021 at 8:24 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Secondary process may not have all the tailq available for
> mapping, so better to ignore the error.
>
> e.g. if the primary process is linked with N libs
> and secondary process is linked with less number of libs.
>
> dpdk-procinfo results into following error:
> EAL: Cannot initialize tailq: VMBUS_RESOURCE_LIST

For dpdk-procinfo to complain about vmbus, it means the bus driver has
been loaded in the secondary, but not in the primary.
Is this what you intend to do?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available
  2021-01-14 13:44 ` David Marchand
@ 2021-01-18  5:55   ` Hemant Agrawal
  2021-03-25 14:16     ` David Marchand
  0 siblings, 1 reply; 6+ messages in thread
From: Hemant Agrawal @ 2021-01-18  5:55 UTC (permalink / raw)
  To: David Marchand, Hemant Agrawal; +Cc: dev, Burakov, Anatoly, Bruce Richardson


On 1/14/2021 7:14 PM, David Marchand wrote:
> On Thu, Jan 14, 2021 at 8:24 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>> Secondary process may not have all the tailq available for
>> mapping, so better to ignore the error.
>>
>> e.g. if the primary process is linked with N libs
>> and secondary process is linked with less number of libs.
>>
>> dpdk-procinfo results into following error:
>> EAL: Cannot initialize tailq: VMBUS_RESOURCE_LIST
> For dpdk-procinfo to complain about vmbus, it means the bus driver has
> been loaded in the secondary, but not in the primary.
> Is this what you intend to do?
>
Yes.

Typically the customer applications are built/linked with only limited  
number of bus, devices

dpdk-procinfo is getting compiled with default list as part of dpdk 
build. so, if customer is trying to use the default dpdk-procinfo with 
their application - there will be differences.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available
  2021-01-18  5:55   ` Hemant Agrawal
@ 2021-03-25 14:16     ` David Marchand
  2021-03-25 16:05       ` Stephen Hemminger
  0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2021-03-25 14:16 UTC (permalink / raw)
  To: Burakov, Anatoly, Bruce Richardson; +Cc: dev, Hemant Agrawal

On Mon, Jan 18, 2021 at 6:55 AM Hemant Agrawal
<hemant.agrawal@oss.nxp.com> wrote:
> On 1/14/2021 7:14 PM, David Marchand wrote:
> > On Thu, Jan 14, 2021 at 8:24 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >> Secondary process may not have all the tailq available for
> >> mapping, so better to ignore the error.
> >>
> >> e.g. if the primary process is linked with N libs
> >> and secondary process is linked with less number of libs.
> >>
> >> dpdk-procinfo results into following error:
> >> EAL: Cannot initialize tailq: VMBUS_RESOURCE_LIST
> > For dpdk-procinfo to complain about vmbus, it means the bus driver has
> > been loaded in the secondary, but not in the primary.
> > Is this what you intend to do?
> >
> Yes.
>
> Typically the customer applications are built/linked with only limited
> number of bus, devices
>
> dpdk-procinfo is getting compiled with default list as part of dpdk
> build. so, if customer is trying to use the default dpdk-procinfo with
> their application - there will be differences.
>

Is this a usecase that we support or we want to support?
Thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available
  2021-03-25 14:16     ` David Marchand
@ 2021-03-25 16:05       ` Stephen Hemminger
  2021-03-25 16:14         ` Bruce Richardson
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2021-03-25 16:05 UTC (permalink / raw)
  To: David Marchand; +Cc: Burakov, Anatoly, Bruce Richardson, dev, Hemant Agrawal

On Thu, 25 Mar 2021 15:16:47 +0100
David Marchand <david.marchand@redhat.com> wrote:

> On Mon, Jan 18, 2021 at 6:55 AM Hemant Agrawal
> <hemant.agrawal@oss.nxp.com> wrote:
> > On 1/14/2021 7:14 PM, David Marchand wrote:  
> > > On Thu, Jan 14, 2021 at 8:24 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:  
> > >> Secondary process may not have all the tailq available for
> > >> mapping, so better to ignore the error.
> > >>
> > >> e.g. if the primary process is linked with N libs
> > >> and secondary process is linked with less number of libs.
> > >>
> > >> dpdk-procinfo results into following error:
> > >> EAL: Cannot initialize tailq: VMBUS_RESOURCE_LIST  
> > > For dpdk-procinfo to complain about vmbus, it means the bus driver has
> > > been loaded in the secondary, but not in the primary.
> > > Is this what you intend to do?
> > >  
> > Yes.
> >
> > Typically the customer applications are built/linked with only limited
> > number of bus, devices
> >
> > dpdk-procinfo is getting compiled with default list as part of dpdk
> > build. so, if customer is trying to use the default dpdk-procinfo with
> > their application - there will be differences.
> >  
> 
> Is this a usecase that we support or we want to support?
> Thanks.
> 
> 

Primary and secondary process have to be built with same DPDK version
and same configuration values.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available
  2021-03-25 16:05       ` Stephen Hemminger
@ 2021-03-25 16:14         ` Bruce Richardson
  0 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2021-03-25 16:14 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: David Marchand, Burakov, Anatoly, dev, Hemant Agrawal

On Thu, Mar 25, 2021 at 09:05:51AM -0700, Stephen Hemminger wrote:
> On Thu, 25 Mar 2021 15:16:47 +0100
> David Marchand <david.marchand@redhat.com> wrote:
> 
> > On Mon, Jan 18, 2021 at 6:55 AM Hemant Agrawal
> > <hemant.agrawal@oss.nxp.com> wrote:
> > > On 1/14/2021 7:14 PM, David Marchand wrote:  
> > > > On Thu, Jan 14, 2021 at 8:24 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:  
> > > >> Secondary process may not have all the tailq available for
> > > >> mapping, so better to ignore the error.
> > > >>
> > > >> e.g. if the primary process is linked with N libs
> > > >> and secondary process is linked with less number of libs.
> > > >>
> > > >> dpdk-procinfo results into following error:
> > > >> EAL: Cannot initialize tailq: VMBUS_RESOURCE_LIST  
> > > > For dpdk-procinfo to complain about vmbus, it means the bus driver has
> > > > been loaded in the secondary, but not in the primary.
> > > > Is this what you intend to do?
> > > >  
> > > Yes.
> > >
> > > Typically the customer applications are built/linked with only limited
> > > number of bus, devices
> > >
> > > dpdk-procinfo is getting compiled with default list as part of dpdk
> > > build. so, if customer is trying to use the default dpdk-procinfo with
> > > their application - there will be differences.
> > >  
> > 
> > Is this a usecase that we support or we want to support?
> > Thanks.
> > 
> > 
> 
> Primary and secondary process have to be built with same DPDK version
> and same configuration values.

I'd like to see support for the information provided by proc-info also
exposed via telemetry callbacks, which would give us an easier way for
tooling to request and process this data. Relying on something using the
multi-process model is always going to have potential issues.

/Bruce

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-25 16:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14  7:13 [dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available Hemant Agrawal
2021-01-14 13:44 ` David Marchand
2021-01-18  5:55   ` Hemant Agrawal
2021-03-25 14:16     ` David Marchand
2021-03-25 16:05       ` Stephen Hemminger
2021-03-25 16:14         ` Bruce Richardson

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git