* [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable
@ 2021-02-03 16:56 Timothy McDaniel
2021-02-03 16:58 ` Jerin Jacob
0 siblings, 1 reply; 4+ messages in thread
From: Timothy McDaniel @ 2021-02-03 16:56 UTC (permalink / raw)
To: jerinj
Cc: mattias.ronnblom, dev, john.mcnamara, harry.van.haaren, timothy.mcdaniel
Fixes: eb14a3421afd ("event/dlb: add eventdev start")
Coverity issue: 366205
Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
drivers/event/dlb/dlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
index 64e6df7..b580dc9 100644
--- a/drivers/event/dlb/dlb.c
+++ b/drivers/event/dlb/dlb.c
@@ -1847,7 +1847,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_create_dir_queue_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int32_t ret;
cfg.response = (uintptr_t)&response;
--
1.7.10
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable
2021-02-03 16:56 [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable Timothy McDaniel
@ 2021-02-03 16:58 ` Jerin Jacob
0 siblings, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2021-02-03 16:58 UTC (permalink / raw)
To: Timothy McDaniel
Cc: Jerin Jacob, Mattias Rönnblom, dpdk-dev, John McNamara,
Van Haaren, Harry
On Wed, Feb 3, 2021 at 10:26 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
Please add a comment and also squash the similar patches.
> Fixes: eb14a3421afd ("event/dlb: add eventdev start")
> Coverity issue: 366205
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
> drivers/event/dlb/dlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
> index 64e6df7..b580dc9 100644
> --- a/drivers/event/dlb/dlb.c
> +++ b/drivers/event/dlb/dlb.c
> @@ -1847,7 +1847,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
> {
> struct dlb_hw_dev *handle = &dlb->qm_instance;
> struct dlb_create_dir_queue_args cfg;
> - struct dlb_cmd_response response;
> + struct dlb_cmd_response response = {0};
> int32_t ret;
>
> cfg.response = (uintptr_t)&response;
> --
> 1.7.10
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable
@ 2021-02-03 16:56 Timothy McDaniel
0 siblings, 0 replies; 4+ messages in thread
From: Timothy McDaniel @ 2021-02-03 16:56 UTC (permalink / raw)
To: jerinj
Cc: mattias.ronnblom, dev, john.mcnamara, harry.van.haaren, timothy.mcdaniel
Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
Coverity issue: 366202
Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
drivers/event/dlb/dlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
index b580dc9..fd03f87 100644
--- a/drivers/event/dlb/dlb.c
+++ b/drivers/event/dlb/dlb.c
@@ -3573,7 +3573,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_get_ldb_queue_depth_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int ret;
cfg.queue_id = queue->qm_queue.id;
--
1.7.10
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable
@ 2021-02-03 16:56 Timothy McDaniel
0 siblings, 0 replies; 4+ messages in thread
From: Timothy McDaniel @ 2021-02-03 16:56 UTC (permalink / raw)
To: jerinj
Cc: mattias.ronnblom, dev, john.mcnamara, harry.van.haaren, timothy.mcdaniel
Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
Coverity issue: 366200
Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
drivers/event/dlb/dlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
index fd03f87..8b26d1d 100644
--- a/drivers/event/dlb/dlb.c
+++ b/drivers/event/dlb/dlb.c
@@ -3595,7 +3595,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_get_dir_queue_depth_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int ret;
cfg.queue_id = queue->qm_queue.id;
--
1.7.10
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-03 16:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 16:56 [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable Timothy McDaniel
2021-02-03 16:58 ` Jerin Jacob
-- strict thread matches above, loose matches on Subject: below --
2021-02-03 16:56 Timothy McDaniel
2021-02-03 16:56 Timothy McDaniel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).