From: Jerin Jacob <jerinjacobk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>,
Jerin Jacob <jerinj@marvell.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
dev <dev@dpdk.org>, nd <nd@arm.com>,
Feifei Wang <feifei.wang2@arm.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0
Date: Fri, 27 Nov 2020 14:21:15 +0530 [thread overview]
Message-ID: <CALBAE1MGienzUb6mGbBhKExua6T8s56dUCBOt58d13rebyzYjg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zNoFDR9=-XROsQDMWuFg+aS-1+ZjL0jOU0K9CfPC_ZYw@mail.gmail.com>
On Fri, Nov 27, 2020 at 2:09 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
> >
> > Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set
> > failed for:
> > ../lib/librte_efd/rte_efd.c
> > Assembler messages:
> > 3866: Error: selected processor does not support `crc32cb w0,w0,w1'
> > 3890: Error: selected processor does not support `crc32ch w0,w0,w1'
> > 3914: Error: selected processor does not support `crc32cw w0,w0,w1'
> > 3938: Error: selected processor does not support `crc32cx w0,w0,x1'
> >
> > This was caused by an architecture specifier added for Clang.
> > Unlike Clang, Gcc considers each inline assembly block to be dependent
> > and therefor, the architecture specifier impacts assemble of some
> > blocks require certain extension support.
>
> I reproduced this error with -O0 for config/arm/arm64_octeontx2_linux_gcc.
> The patch looks simple enough and it only affects ARM builds.
>
> Jerin,
> Are you okay with this change for 20.11?
> Or should we wait 21.02?
I could reproduce the issue with meson build -Dbuildtype=debug
--cross-file config/arm/arm64_octeontx2_linux_gcc
This fix is OK. Request to merge for 20.11
Acked-by: Jerin Jacob <jerinj@marvell.com>
>
> Ruifeng,
> Looking at the kernel, I see no distinction with gcc/clang, so I'd say
> the kernel has the same issue, or is there something else that differs
> in dpdk?
> Besides, the kernel patch previously mentioned had a followup fix.
>
>
> --
> David Marchand
>
next prev parent reply other threads:[~2020-11-27 8:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 8:09 [dpdk-dev] [PATCH 0/2] gcc build fix Ruifeng Wang
2020-11-27 8:09 ` [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0 Ruifeng Wang
2020-11-27 8:39 ` David Marchand
2020-11-27 8:51 ` Jerin Jacob [this message]
2020-11-27 9:25 ` David Marchand
2020-11-27 9:33 ` Jerin Jacob
2020-11-27 9:45 ` David Marchand
2020-11-27 10:05 ` Ruifeng Wang
2020-11-27 10:28 ` Jerin Jacob
2020-11-27 9:39 ` Andrew Rybchenko
2020-11-27 9:36 ` Ruifeng Wang
2020-11-27 8:09 ` [dpdk-dev] [PATCH 2/2] net/igc: " Ruifeng Wang
2020-11-27 8:53 ` Jerin Jacob
2020-11-27 9:02 ` David Marchand
2020-11-27 12:13 ` David Marchand
2020-11-27 14:50 ` Wang, Haiyue
2020-11-27 10:15 ` [dpdk-dev] [PATCH v2 0/2] gcc build fix Ruifeng Wang
2020-11-27 10:15 ` [dpdk-dev] [PATCH v2 1/2] eal/arm: fix gcc build for optimization level 0 Ruifeng Wang
2020-11-27 13:03 ` Ruifeng Wang
2020-11-27 10:15 ` [dpdk-dev] [PATCH v2 2/2] net/igc: " Ruifeng Wang
2020-11-27 13:35 ` [dpdk-dev] [PATCH v2 0/2] gcc build fix Thomas Monjalon
2020-11-27 14:08 ` Ruifeng Wang
2020-11-27 16:03 ` [dpdk-dev] [PATCH " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1MGienzUb6mGbBhKExua6T8s56dUCBOt58d13rebyzYjg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).