From: Jerin Jacob <jerinjacobk@gmail.com>
To: Xiaojun Liu <xiaojun.liu@silicom.co.il>
Cc: "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"ngai-mint.kwan@intel.com" <ngai-mint.kwan@intel.com>,
"jakub.fornal@intel.co" <jakub.fornal@intel.co>,
"jacob.e.keller@intel.com" <jacob.e.keller@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Jeff Zheng <jeff.zheng@silicom.co.il>,
Eyal Cohen <eyalc@silicom.co.il>
Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition
Date: Thu, 12 Dec 2019 22:42:21 +0530 [thread overview]
Message-ID: <CALBAE1MNDWvU4X0BDB64FwBu76qUccksqQ_SDTC8NBZpD2bbOA@mail.gmail.com> (raw)
In-Reply-To: <DB7PR04MB5196F6C43538586E8C462EEDBD550@DB7PR04MB5196.eurprd04.prod.outlook.com>
On Thu, Dec 12, 2019 at 3:05 PM Xiaojun Liu <xiaojun.liu@silicom.co.il> wrote:
>
> This is not a generic i2c bus, but rather an indirect access to i2c devices through FM10k registers. It's only purpose is to support the fm10k chip. Also there's currently no i2c bus support framework in DPDK.
To understand it better:
# Who are the i2c master and i2c slave here?
# Is i2c slave connected on board or in-built to FM10K SoC?
# What is the purpose of the i2c API in the ethdev driver?
>
> -----Original Message-----
> From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
> Sent: Wednesday, December 11, 2019 11:48 PM
> To: Xiaojun Liu
> Cc: xiao.w.wang@intel.com; qi.z.zhang@intel.com; ngai-mint.kwan@intel.com; jakub.fornal@intel.co; jacob.e.keller@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition
>
> On Wed, Dec 11, 2019 at 3:22 PM Xiaojun Liu <xiaojun.liu@silicom.co.il> wrote:
> >
> > To support switch management, add the following files:
> > Add fm10k/switch/fm10k_debug.h(define log Macros).
> > Add fm10k/switch/fm10k_regs.h(define all the registers).
> > Add fm10k/switch/fm10k_switch.h(define switch Macros and APIs).
> > Add fm10k/switch/fm10k_i2c.h(define I2C interfaces).
> > Add fm10k/switch/fm10k_i2c.c(support I2C access).
> > Add fm10k/switch/fm10k_sbus.h(define SBUS interface).
> > Add fm10k/switch/fm10k_sbus.c(support SBUS access).
> > and modify fm10k/Makefile(add ENABLE_FM10K_MANAGEMENT support,
> > add fm10k_i2c.c and fm10k_sbus.c).
>
> Integrating NIC with the integrated or onboard switches over i2c or
> sbus is a common problem.
> Instead of polluting ethdev driver with i2c and sbus _bus_ code, Why
> not add new i2c bus
> and move this code to driver/bus/i2c/xxxx/
>
> >
> > To avoid configuration for both kernel driver
> > and userspace SDK outside DPDK, we add switch
> > management in FM10K DPDK PMD driver.
> > To enable switch management, you need add
> > CONFIG_RTE_FM10K_MANAGEMENT=y in
> > config/common_linux when building.
> >
> > Signed-off-by: Xiaojun Liu <xiaojun.liu@silicom.co.il>
next prev parent reply other threads:[~2019-12-12 17:12 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 9:51 [dpdk-dev] [PATCH v2 0/7] support switch management Xiaojun Liu
2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition Xiaojun Liu
2019-12-11 15:48 ` Jerin Jacob
2019-12-12 9:35 ` Xiaojun Liu
2019-12-12 17:12 ` Jerin Jacob [this message]
2019-12-13 2:44 ` Xiaojun Liu
2019-12-16 4:54 ` Jerin Jacob
2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 0/5] support switch management Xiaojun Liu
2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 1/5] net/fm10k: add basic functions for " Xiaojun Liu
2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 0/5] support fm10k " Xiaojun Liu
2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 1/5] net/fm10k: add basic functions for " Xiaojun Liu
2020-03-16 6:37 ` Wang, Xiao W
2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu
2020-03-16 6:48 ` Wang, Xiao W
2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu
2020-03-16 7:04 ` Wang, Xiao W
2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu
2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 5/5] net/fm10k: add switch management support Xiaojun Liu
2020-03-16 7:34 ` Wang, Xiao W
2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 0/5] support fm10k switch management Xiaojun Liu
2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for " Xiaojun Liu
2020-04-02 8:41 ` Wang, Xiao W
2020-04-08 3:25 ` Xiaojun Liu
2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu
2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu
2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu
2020-04-02 8:55 ` Wang, Xiao W
2020-04-09 6:24 ` Xiaojun Liu
2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support Xiaojun Liu
2020-04-02 9:12 ` Wang, Xiao W
2020-04-09 6:32 ` Xiaojun Liu
2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu
2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu
2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu
2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support Xiaojun Liu
2020-02-25 11:28 ` Wang, Xiao W
2020-02-25 12:56 ` Xiaojun Liu
2020-03-05 1:23 ` Xiaojun Liu
2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 2/7] net/fm10k: add some modules of port Xiaojun Liu
2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 3/7] net/fm10k: add config ffu statistics support Xiaojun Liu
2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 4/7] net/fm10k: add flow and switch management Xiaojun Liu
2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 5/7] net/fm10k: add switch initialization Xiaojun Liu
2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 6/7] net/fm10k: add mirror and filter ctrl Xiaojun Liu
2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 7/7] net/fm10k: add dpdk port mapping Xiaojun Liu
2020-01-21 2:53 ` [dpdk-dev] [PATCH v2 0/7] support switch management Wang, Xiao W
2020-01-21 6:15 ` Xiaojun Liu
2020-02-11 10:31 ` Wang, Xiao W
2020-02-14 2:46 ` Xiaojun Liu
[not found] ` <ORIGINAL-RELEASE-1581835643311863404-DB7PR04MB5196A5418792DFB1F96DB8B7BD150@DB7PR04MB5196.eurprd04.prod.outlook.com>
2020-02-19 5:58 ` Xiaojun Liu
2020-02-19 10:56 ` Wang, Xiao W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1MNDWvU4X0BDB64FwBu76qUccksqQ_SDTC8NBZpD2bbOA@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=eyalc@silicom.co.il \
--cc=jacob.e.keller@intel.com \
--cc=jakub.fornal@intel.co \
--cc=jeff.zheng@silicom.co.il \
--cc=ngai-mint.kwan@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaojun.liu@silicom.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).