From: Xiaojun Liu <xiaojun.liu@silicom.co.il> To: "Wang, Xiao W" <xiao.w.wang@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Kwan, Ngai-mint" <ngai-mint.kwan@intel.com>, "Keller, Jacob E" <jacob.e.keller@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support Date: Thu, 9 Apr 2020 06:32:57 +0000 Message-ID: <VI1PR04MB51502C05455E8E5062311360BDC10@VI1PR04MB5150.eurprd04.prod.outlook.com> (raw) In-Reply-To: <BN6PR11MB147352E6DFE4C50478EEBBEDB8C60@BN6PR11MB1473.namprd11.prod.outlook.com> Hi Xiao, Thank you! I add release note and remove the DEV_RX_OFFLOAD_RSS_HASH modification(It may be a mistake). I submit the new patch again:) Best regards, Xiaojun -----Original Message----- From: Wang, Xiao W [mailto:xiao.w.wang@intel.com] Sent: Thursday, April 02, 2020 5:12 PM To: Xiaojun Liu; Zhang, Qi Z; Kwan, Ngai-mint; Keller, Jacob E Cc: dev@dpdk.org Subject: RE: [PATCH v3 5/5] net/fm10k: add switch management support Hi, This is a feature-add patch, so you need to add release note in doc/guides/rel_notes/release_20_05.rst, that can be included as part of this 5/5 patch. Another issue, why delete DEV_RX_OFFLOAD_RSS_HASH unconditionally? I think it would impact the existing usage. @@ -1808,8 +2044,7 @@ static uint64_t fm10k_get_rx_port_offloads_capa(struct rte_eth_dev *dev) DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM | DEV_RX_OFFLOAD_JUMBO_FRAME | - DEV_RX_OFFLOAD_HEADER_SPLIT | - DEV_RX_OFFLOAD_RSS_HASH); + DEV_RX_OFFLOAD_HEADER_SPLIT); Also some comments on the feature description are inlined below. Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu <xiaojun.liu@silicom.co.il> > Sent: Friday, March 20, 2020 2:59 PM > To: Wang, Xiao W <xiao.w.wang@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com>; Kwan, Ngai-mint <ngai-mint.kwan@intel.com>; Keller, > Jacob E <jacob.e.keller@intel.com> > Cc: dev@dpdk.org; Xiaojun Liu <xiaojun.liu@silicom.co.il> > Subject: [PATCH v3 5/5] net/fm10k: add switch management support > > Split dev init to 2 parts. > First only register the port in switch > management; second init hook will be > called after all the pf are registered > and switch initialization. It will finish > dev init. Also add switch interrupt support. > Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset > to support mirror operation. Add fm10k_dev_filter_ctrl > to support flow operation. > Add dpdk port and pf mapping, so > the dpdk port can map to a specific pf > and 1 dpdk port can map to 2 pf to get > total 100G throughput. Update fm10k.rst. > > Signed-off-by: Xiaojun Liu <xiaojun.liu@silicom.co.il> > --- > doc/guides/nics/fm10k.rst | 5 + > drivers/net/fm10k/fm10k_ethdev.c | 559 > ++++++++++++++++++++++++++++++++++++--- > 2 files changed, 525 insertions(+), 39 deletions(-) > > diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst > index 4e178c2..75f9929 100644 > --- a/doc/guides/nics/fm10k.rst > +++ b/doc/guides/nics/fm10k.rst > @@ -124,6 +124,11 @@ FM10000 PMD driver. The switch driver can be > acquired from Intel support. > Only Testpoint is validated with DPDK, the latest version that has been > validated with DPDK is 4.1.6. > > +To avoid loading other switch driver from outside of DPDK, there is another > +way to load switch driver in DPDK. If you want to use the inline switch driver, "There is a way to load..." Since what you do is the only way to load switch driver inside DPDK. > +you need to set ''CONFIG_RTE_FM10K_SWITCH_MANAGEMENT=y'' in the > configure file. Configuration file. > +The inline switch driver supports mirror and some flow forward rules. Please be clear on what forwarding rules are supported. Any doc reader will be confused by "some". > + > Support for Switch Restart > ~~~~~~~~~~~~~~~~~~~~~~~~~~ [...]
next prev parent reply other threads:[~2020-04-09 6:33 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-11 9:51 [dpdk-dev] [PATCH v2 0/7] support switch management Xiaojun Liu 2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition Xiaojun Liu 2019-12-11 15:48 ` Jerin Jacob 2019-12-12 9:35 ` Xiaojun Liu 2019-12-12 17:12 ` Jerin Jacob 2019-12-13 2:44 ` Xiaojun Liu 2019-12-16 4:54 ` Jerin Jacob 2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 0/5] support switch management Xiaojun Liu 2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 1/5] net/fm10k: add basic functions for " Xiaojun Liu 2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 0/5] support fm10k " Xiaojun Liu 2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 1/5] net/fm10k: add basic functions for " Xiaojun Liu 2020-03-16 6:37 ` Wang, Xiao W 2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu 2020-03-16 6:48 ` Wang, Xiao W 2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu 2020-03-16 7:04 ` Wang, Xiao W 2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu 2020-02-28 8:38 ` [dpdk-dev] [PATCH v1 5/5] net/fm10k: add switch management support Xiaojun Liu 2020-03-16 7:34 ` Wang, Xiao W 2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 0/5] support fm10k switch management Xiaojun Liu 2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for " Xiaojun Liu 2020-04-02 8:41 ` Wang, Xiao W 2020-04-08 3:25 ` Xiaojun Liu 2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu 2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu 2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu 2020-04-02 8:55 ` Wang, Xiao W 2020-04-09 6:24 ` Xiaojun Liu 2020-03-20 6:58 ` [dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support Xiaojun Liu 2020-04-02 9:12 ` Wang, Xiao W 2020-04-09 6:32 ` Xiaojun Liu [this message] 2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu 2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu 2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu 2020-02-20 13:59 ` [dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support Xiaojun Liu 2020-02-25 11:28 ` Wang, Xiao W 2020-02-25 12:56 ` Xiaojun Liu 2020-03-05 1:23 ` Xiaojun Liu 2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 2/7] net/fm10k: add some modules of port Xiaojun Liu 2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 3/7] net/fm10k: add config ffu statistics support Xiaojun Liu 2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 4/7] net/fm10k: add flow and switch management Xiaojun Liu 2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 5/7] net/fm10k: add switch initialization Xiaojun Liu 2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 6/7] net/fm10k: add mirror and filter ctrl Xiaojun Liu 2019-12-11 9:52 ` [dpdk-dev] [PATCH v2 7/7] net/fm10k: add dpdk port mapping Xiaojun Liu 2020-01-21 2:53 ` [dpdk-dev] [PATCH v2 0/7] support switch management Wang, Xiao W 2020-01-21 6:15 ` Xiaojun Liu 2020-02-11 10:31 ` Wang, Xiao W 2020-02-14 2:46 ` Xiaojun Liu [not found] ` <ORIGINAL-RELEASE-1581835643311863404-DB7PR04MB5196A5418792DFB1F96DB8B7BD150@DB7PR04MB5196.eurprd04.prod.outlook.com> 2020-02-19 5:58 ` Xiaojun Liu 2020-02-19 10:56 ` Wang, Xiao W
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR04MB51502C05455E8E5062311360BDC10@VI1PR04MB5150.eurprd04.prod.outlook.com \ --to=xiaojun.liu@silicom.co.il \ --cc=dev@dpdk.org \ --cc=jacob.e.keller@intel.com \ --cc=ngai-mint.kwan@intel.com \ --cc=qi.z.zhang@intel.com \ --cc=xiao.w.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git