DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Timothy McDaniel <timothy.mcdaniel@intel.com>,
	 Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Ray Kinsella <mdr@ashroe.eu>, Aaron Conole <aconole@redhat.com>,
	dpdklab <dpdklab@iol.unh.edu>,
	 "abhinandan.gujjar@intel.com" <abhinandan.gujjar@intel.com>,
	 "harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
	dev <dev@dpdk.org>,  Shijith Thotton <sthotton@marvell.com>,
	Akhil Goyal <gakhil@marvell.com>,
	 Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	 "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
	ci@dpdk.org
Subject: Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
Date: Tue, 13 Apr 2021 14:24:43 +0530
Message-ID: <CALBAE1O6V+pN0p55_LsYsKiYmqHNk1rfaXuYn-bLgVVpbxruDQ@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8x0-8pWr4mj86n=wzmX5jxS9C5D-jqEW+d8z3vcc+AABA@mail.gmail.com>

On Tue, Apr 13, 2021 at 12:46 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> > >   http://dpdk.org/git/next/dpdk-next-eventdev
> >
> > Pulled, thanks.
> >
> > Note few changes in titles like uppercases for acronyms,
> > or "add support" simplified as "support",
> > and release notes moved in the right place.
>
> The ABI check now reports an error on event/dlb.
> The reason is that the event/dlb driver has been removed, and so the
> check complains about a missing dump.
> This will have to be fixed quickly or reverted.
>
>
> This has been missed by multiple people, so trying to understand why.


I was running the following script[1] to detect ABI issues.
Since the "./devtools/test-meson-builds.sh" did not return non zero value or
the error print was "Error: cannot find librte_event_dlb.dump", It is
missed from my side.

@David Marchand  @Thomas Monjalon Could you share the snippet you are
using for detecting the ABI issue.


------------------------
# ABI check
DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log
if [ $? -ne 0 ]; then
        echo "ABI check failed"
        exit
fi

grep "Error: ABI issue reported" /tmp/build.log
if [ $? -eq 0 ]; then
        echo "ABI issue"
        exit
fi

-------------------------------------------------------
>
> The ABI check should have caught this when run by maintainers (/me
> looks at Thomas and Jerin).

Sorry for that :-(

  parent reply	other threads:[~2021-04-13  8:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 13:20 Jerin Jacob Kollanukkaran
2021-04-12 13:27 ` McDaniel, Timothy
2021-04-12 13:40   ` Jerin Jacob
2021-04-12 22:12 ` Thomas Monjalon
2021-04-13  7:15   ` David Marchand
2021-04-13  7:31     ` Thomas Monjalon
2021-04-13  8:45     ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
2021-04-13  9:15       ` David Marchand
2021-04-13  9:32         ` Thomas Monjalon
2021-04-13 16:09       ` Kinsella, Ray
2021-04-13 16:44         ` Thomas Monjalon
2021-04-13 16:45           ` Kinsella, Ray
2021-04-13  8:54     ` Jerin Jacob [this message]
2021-04-13  9:01       ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Thomas Monjalon
2021-04-13  9:07       ` David Marchand
2021-04-13  9:12         ` Thomas Monjalon
2021-04-13  9:14         ` David Marchand
2021-04-13 12:58     ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1O6V+pN0p55_LsYsKiYmqHNk1rfaXuYn-bLgVVpbxruDQ@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=aconole@redhat.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dpdklab@iol.unh.edu \
    --cc=gakhil@marvell.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=mdr@ashroe.eu \
    --cc=pbhagavatula@marvell.com \
    --cc=sthotton@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git