From: Jerin Jacob <jerinjacobk@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Robin Jarry <rjarry@redhat.com>,
dev@dpdk.org, skori@marvell.com, thomas@monjalon.net
Subject: Re: [PATCH 1/2] usertools/rss: add driver abstractions
Date: Tue, 21 Nov 2023 22:51:19 +0530 [thread overview]
Message-ID: <CALBAE1OH5Z8F-gJzyMc4FTCEus9xdG+CECxm9Xp=BEfv3FB6fg@mail.gmail.com> (raw)
In-Reply-To: <20231121090423.639655f4@hermes.local>
On Tue, Nov 21, 2023 at 10:34 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 21 Nov 2023 22:21:54 +0530
> Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> > > The tool should not need to have driver specific tables like this.
> > > DPDK is already riddled with enough driver specific quirks..
> > >
> > > That shows a flaw in the rss design, which should have been fixed.
> >
> > Every NIC's implements standard Toeplitz hash algorithm for RSS hash generation.
> > Only the initial SEED is different. It is not DPDK property, all the
> > HW like is that as
> > there is no standardization on initial SEED for hash.
>
> The tool should be able to query the default key from driver, or the
> build infrastructure should extract and generate the table.
IMO, That may be too much of non-productive work to save a couple of
lines(seed array) of duplicate code between c and python.
next prev parent reply other threads:[~2023-11-21 17:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 8:07 Robin Jarry
2023-10-23 8:07 ` [PATCH 2/2] usertools/rss: add --info flag Robin Jarry
2023-11-20 13:28 ` [PATCH 1/2] usertools/rss: add driver abstractions Robin Jarry
2023-11-20 15:13 ` [EXT] " Sunil Kumar Kori
2023-11-20 16:22 ` [PATCH v2 1/3] " Robin Jarry
2023-11-20 16:22 ` [PATCH v2 2/3] usertools/rss: add --info flag Robin Jarry
2023-11-21 6:15 ` [EXT] " Sunil Kumar Kori
2023-11-20 16:22 ` [PATCH v2 3/3] usertools/rss: add CNXK well-known key Robin Jarry
2023-11-20 16:41 ` Stephen Hemminger
2023-11-21 6:08 ` [EXT] " Sunil Kumar Kori
2023-11-21 6:14 ` [EXT] [PATCH v2 1/3] usertools/rss: add driver abstractions Sunil Kumar Kori
2023-11-22 23:43 ` Thomas Monjalon
2023-11-21 6:11 ` [EXT] [PATCH 1/2] " Sunil Kumar Kori
2023-11-21 16:38 ` Stephen Hemminger
2023-11-21 16:49 ` Thomas Monjalon
2023-11-21 16:51 ` Jerin Jacob
2023-11-21 17:04 ` Stephen Hemminger
2023-11-21 17:21 ` Jerin Jacob [this message]
2023-11-21 17:27 ` Stephen Hemminger
2023-11-22 8:28 ` Robin Jarry
2023-11-22 9:37 ` fengchengwen
2023-11-22 23:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1OH5Z8F-gJzyMc4FTCEus9xdG+CECxm9Xp=BEfv3FB6fg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=skori@marvell.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).