From: Muhammad Bilal <m.bilal@emumba.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted
Date: Tue, 2 Jun 2020 16:42:22 +0500 [thread overview]
Message-ID: <CAOFC0T1NDpqBh=YoL4e2hJwUvoRW0KAadamV3OoL+zTmu_r-Uw@mail.gmail.com> (raw)
In-Reply-To: <20200527135914.05e624ff@hermes.lan>
Thank you for your response.
How will we know if a patch is failing because of some failure in the
CI infrastructure or due to earlier merge?
On Thu, May 28, 2020 at 1:59 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Thu, 28 May 2020 01:13:27 +0500
> Muhammad Bilal <m.bilal@emumba.com> wrote:
>
> > Recently I have submitted patches and some tests were failing on patchwork.
> > My question is, which tests are compulsory to pass for a patch to be accepted.
> > As in the below mentioned patch, it is accepted while 1 test was still failing.
> > http://patches.dpdk.org/patch/70348/
> >
> > kind regards.
> > Muhammad Bilal
>
> There are two different issues:
> 1. A patch should not get blamed for some failure in the CI infrastructure.
> Or collataral damage from an earlier merge.
> 2. A patch must not introduce a failure. I.e. if all tests passed before
> each patch in a patchset must pass.
prev parent reply other threads:[~2020-06-02 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 20:13 Muhammad Bilal
2020-05-27 20:59 ` Stephen Hemminger
2020-06-02 11:42 ` Muhammad Bilal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOFC0T1NDpqBh=YoL4e2hJwUvoRW0KAadamV3OoL+zTmu_r-Uw@mail.gmail.com' \
--to=m.bilal@emumba.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).