From: Muhammad Bilal <m.bilal@emumba.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: beilei.xing@intel.com, xiaolong.ye@intel.com, dev@dpdk.org,
stable@dpdk.org, zijie.pan@6wind.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net/i40e: fixed misplaced arguments
Date: Thu, 16 Jul 2020 09:58:47 +0500 [thread overview]
Message-ID: <CAOFC0T1WxR2XJw1dgvsy-OWTYK9VxAt-ixG71x6TQahnUytxeQ@mail.gmail.com> (raw)
In-Reply-To: <093266f0-1938-026e-1d7e-71db9ee92499@intel.com>
Yes, This is the patch for the same bug, Which is already fixed. So
this duplicate patch can be ignored.
On Tue, Jul 14, 2020 at 9:54 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 7/14/2020 4:58 PM, Muhammad Bilal wrote:
> > Here I have corrected a misplaced argument of i40e_aq_get_phy_register()
> > This was also evident after seeing the datatype of its arguments.
> >
> > Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e")
> > Cc: zijie.pan@6wind.com
> >
> > Bugzilla ID: 506
> > Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> > index 970a31cb2..5fdfadf7b 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct rte_eth_dev *dev,
> > }
> > status = i40e_aq_get_phy_register(hw,
> > I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
> > - addr, offset, 1, &value, NULL);
> > + addr, 1, offset, &value, NULL);
> > if (status)
> > return -EIO;
> > data[i] = (uint8_t)value;
> >
>
> Hi Muhammad,
>
> This seems already fixed [1], can you please double check in the 'v20.08-rc1'?
>
>
>
> [1]
> https://git.dpdk.org/dpdk/commit/?id=2fc1d6da882563ab80786d69b6d7c9d0e4ce860a
> https://patches.dpdk.org/patch/72827/
prev parent reply other threads:[~2020-07-16 4:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 15:58 [dpdk-dev] " Muhammad Bilal
2020-07-14 16:54 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-07-16 4:58 ` Muhammad Bilal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOFC0T1WxR2XJw1dgvsy-OWTYK9VxAt-ixG71x6TQahnUytxeQ@mail.gmail.com \
--to=m.bilal@emumba.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=zijie.pan@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).