From: Ankur Dwivedi <adwivedi@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>,
"royzhang1980@gmail.com" <royzhang1980@gmail.com>,
Amit Prakash Shukla <amitprakashs@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch
Date: Wed, 12 Oct 2022 15:16:43 +0000 [thread overview]
Message-ID: <CO3PR18MB500555011451DDAFA64A83F8DD229@CO3PR18MB5005.namprd18.prod.outlook.com> (raw)
In-Reply-To: <6793875.kQq0lBPeGt@thomas>
>-----Original Message-----
>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Wednesday, October 12, 2022 6:39 PM
>To: Ankur Dwivedi <adwivedi@marvell.com>
>Cc: dev@dpdk.org; Akhil Goyal <gakhil@marvell.com>;
>royzhang1980@gmail.com; Amit Prakash Shukla <amitprakashs@marvell.com>;
>Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Ankur Dwivedi
><adwivedi@marvell.com>; david.marchand@redhat.com
>Subject: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch
>
>External Email
>
>----------------------------------------------------------------------
>12/10/2022 13:45, Ankur Dwivedi:
>> devtools/check-symbol-change.sh | 76 +-------------------------------
>> devtools/check-tracepoint.py | 52 ++++++++++++++++++++++
>> devtools/check-tracepoint.sh | 66 ++++++++++++++++++++++++++++
>> devtools/checkpatches.sh | 9 ++++
>> devtools/common-func.sh | 77 +++++++++++++++++++++++++++++++++
>> devtools/trace-skiplist.txt | 0
>
>Before diving into this proposal,
>I would like a split of the patch for the rework (and move) of check-symbol-
>change.sh alone.
Will split the patch in next version.
>
>In general I see too many files added:
> check-tracepoint.py and check-tracepoint.sh common-func.sh is
>probably a bad name.
Regarding common-func.sh name, I am thinking of renaming it to common.sh or helper.sh, considering there may be more common shell routines in future. Otherwise it can be renamed to build-map.sh considering it will contain only build_map_changes() function.
Please suggest a suitable name if my suggested names are bad.
Will try to combine check-tracepoint.py and check-tracepoint.sh.
>
next prev parent reply other threads:[~2022-10-12 15:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 9:23 [PATCH] " Ankur Dwivedi
2022-10-12 11:45 ` [PATCH v2] " Ankur Dwivedi
2022-10-12 13:08 ` Thomas Monjalon
2022-10-12 15:16 ` Ankur Dwivedi [this message]
2022-10-12 16:19 ` [EXT] " Thomas Monjalon
2022-10-15 12:58 ` [PATCH v3 0/2] " Ankur Dwivedi
2022-10-15 12:58 ` [PATCH v3 1/2] devtools: move build symbol map function Ankur Dwivedi
2022-10-15 12:58 ` [PATCH v3 2/2] devtools: add tracepoint check in checkpatch Ankur Dwivedi
2022-11-02 4:08 ` [PATCH v3 0/2] " Ankur Dwivedi
2023-03-03 15:58 ` [PATCH v4 " Ankur Dwivedi
2023-03-03 15:58 ` [PATCH v4 1/2] devtools: move build symbol map function Ankur Dwivedi
2023-03-03 15:58 ` [PATCH v4 2/2] devtools: add tracepoint check in checkpatch Ankur Dwivedi
2023-03-07 12:05 ` [PATCH v5 0/1] " Ankur Dwivedi
2023-03-07 12:05 ` [PATCH v5 1/1] " Ankur Dwivedi
2023-05-18 13:45 ` Ankur Dwivedi
2023-05-18 15:33 ` Stephen Hemminger
2023-08-21 13:53 ` [EXT] " Ankur Dwivedi
2023-08-21 14:46 ` Morten Brørup
2023-08-30 16:23 ` Thomas Monjalon
2023-08-30 18:38 ` Morten Brørup
2023-09-01 2:32 ` Jerin Jacob
2023-09-01 7:28 ` Thomas Monjalon
2023-11-14 13:15 ` Ankur Dwivedi
2023-11-28 13:18 ` [PATCH v5 0/1] " Thomas Monjalon
2023-11-28 14:07 ` [EXT] " Ankur Dwivedi
2023-11-28 15:55 ` Thomas Monjalon
2023-11-30 5:56 ` Ankur Dwivedi
2023-11-30 8:40 ` Thomas Monjalon
2023-11-30 13:16 ` Ankur Dwivedi
2023-12-15 6:43 ` [PATCH v6 0/2] " Ankur Dwivedi
2023-12-15 6:43 ` [PATCH v6 1/2] devtools: move build map changes function Ankur Dwivedi
2023-12-15 6:43 ` [PATCH v6 2/2] devtools: add tracepoint check in checkpatch Ankur Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO3PR18MB500555011451DDAFA64A83F8DD229@CO3PR18MB5005.namprd18.prod.outlook.com \
--to=adwivedi@marvell.com \
--cc=amitprakashs@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=royzhang1980@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).