From: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Cui, KaixinX" <kaixinx.cui@intel.com>
Subject: RE: [PATCH] net/ice: support for more flexible loading of DDP package
Date: Wed, 28 Aug 2024 08:53:05 +0000 [thread overview]
Message-ID: <CO6PR11MB56022E58D2A2CFB13956E247F1952@CO6PR11MB5602.namprd11.prod.outlook.com> (raw)
In-Reply-To: <Zs7X6T0iNF7BVCCo@bricha3-mobl1.ger.corp.intel.com>
> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Wednesday, August 28, 2024 3:55 PM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] net/ice: support for more flexible loading of DDP package
>
> On Wed, Aug 28, 2024 at 11:53:35AM +0800, Zhichao Zeng wrote:
> > The "Dynamic Device Personalization" package is loaded at
> > initialization time by the driver, but the specific package file
> > loaded depends upon what package file is found first by searching
> > through a hard-coded list of firmware paths.
> >
> > To enable greater control over the package loading, this commit two
> > ways to support custom DDP packages:
> > 1. Add device option to choose a specific DDP package file to load.
> > For example:
> > -a 80:00.0,ddp_pkg_file=/path/to/ice-version.pkg
> > 2. Read firmware search path from
> > "/sys/module/firmware_class/parameters/path" like the kernel behavior.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> Hi Zhichao,
>
> since there are two different methods being supported for picking a DDP
> package this patch would be better split into two, one for each method added.
>
> The support for #1 above is already on-list as a standalone patch[1], so you
> really only need to do a new patch for #2 above. However, I'm ok for you to
> take my patch and include it in a 2-patch set for this if you prefer, since both
> patches will be related to choosing a DDP file. I'll leave it up to you whether v2
> is a single patch for the search path, or a 2-patch set including [1].
>
> Regards,
> /Bruce
>
> [1]
> https://patches.dpdk.org/project/dpdk/patch/20240812152815.1132697-
> 5-bruce.richardson@intel.com/
>
Hi Bruce,
Thanks for your comments, sorry I didn't check the patchwork and didn't notice that #1 had been submitted, I'll rework the patch for #2 separately, thanks.
Regards
Zhichao
> > ---
> > doc/guides/nics/ice.rst | 12 +++++++
> > drivers/net/ice/ice_ethdev.c | 61
> > ++++++++++++++++++++++++++++++++++++
> > drivers/net/ice/ice_ethdev.h | 2 ++
> > 3 files changed, 75 insertions(+)
> >
<Snip>
next prev parent reply other threads:[~2024-08-28 8:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 3:53 Zhichao Zeng
2024-08-28 7:55 ` Bruce Richardson
2024-08-28 8:53 ` Zeng, ZhichaoX [this message]
2024-08-29 3:35 ` [PATCH v2] net/ice: support customized search path for " Zhichao Zeng
2024-08-29 3:41 ` Zhichao Zeng
2024-09-09 12:13 ` Bruce Richardson
2024-09-12 7:47 ` [PATCH v3] " Zhichao Zeng
2024-09-12 8:01 ` Zhichao Zeng
2024-09-13 6:15 ` [PATCH v4] " Zhichao Zeng
2024-09-13 10:57 ` Bruce Richardson
2024-09-19 3:29 ` [PATCH v5] " Zhichao Zeng
2024-09-19 7:49 ` Bruce Richardson
2024-09-20 8:34 ` Zeng, ZhichaoX
2024-09-20 9:04 ` Bruce Richardson
2024-09-20 10:05 ` [PATCH v6] " Zhichao Zeng
2024-10-01 13:54 ` Bruce Richardson
2024-10-01 14:03 ` Bruce Richardson
-- strict thread matches above, loose matches on Subject: below --
2024-08-28 1:57 [PATCH] net/ice: support for more flexible loading of " Zhichao Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR11MB56022E58D2A2CFB13956E247F1952@CO6PR11MB5602.namprd11.prod.outlook.com \
--to=zhichaox.zeng@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kaixinx.cui@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).