RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

[Akhil Goyal <gakhil@marvell.com>]

> -----Original Message-----
> From: Fangming Fang <Fangming.Fang@arm.com>
> Sent: Thursday, June 15, 2023 8:16 AM
> To: Akhil Goyal <gakhil@marvell.com>; thomas@monjalon.net; Ciara Power
> <ciara.power@intel.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; kai.ji@intel.com; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> john.mcnamara@intel.com
> Cc: dev@dpdk.org; david.marchand@redhat.com; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Ashwin Sekhar T K <asekhar@marvell.com>
> Subject: RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID
> 
> > From: Akhil Goyal <gakhil@marvell.com>
> > > 16/05/2023 17:24, Ciara Power:
> > > > From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > >
> > > > When creating a session, get the session ID that defines the fixed
> > > > session parameters and store it in the private data.
> > > > When retrieving IMB_JOB's, if their internal session ID matches the
> > > > one in the private session data, these fixed session parameters do
> > > > not need to be filled again.
> > > >
> > > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > > [...]
> > > > +#if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM
> > > > + sess->session_id = imb_set_session(mb_mgr, &sess->template_job);
> > > > +#endif
> > >
> > > For info, this does not compile with
> > > https://git.gitlab.arm.com/arm-reference-solutions/ipsec-mb
> > > because Arm did not merge Intel's code correctly, and
> > > imb_set_session() is missing while version is 1.4.0-dev.
> > >
> > > Anyway I hate this situation having 2 repos for the same thing.
> > > Please merge Arm code in the original repository from Intel.
> > >
> > Is it possible to make Arm repo as main repo and modify DPDK documentation,
> > if Intel not agreeing to include Arm code?
> > Currently the Arm repo use case is broken.
> > If it is not resolved soon, we can submit a patch to revert the patch which is
> > breaking compilation. This need to be fixed by RC2.
> 
> It would be better if the original repo can merge Arm changes. We will keep
> regular sync with original repo in the current situation, the next sync will be
> carried out earlier in Q3.

Yes, it is better to keep original repo. But if Intel is not agreeing to it,
We may need to find some alternate way to fix it.
We need a sync as soon as possible, as with current Arm repo,
DPDK compilation is broken.

For now, we cannot merge anything in ipsec_mb driver till we fix the compilation
With Arm repo - either by Arm repo sync or by reverting the patches.

Regards,
Akhil