* [PATCH] examples/fips_validation: fix typo
@ 2022-11-07 9:58 Pablo de Lara
2022-11-07 10:03 ` [PATCH v2] " Pablo de Lara
0 siblings, 1 reply; 4+ messages in thread
From: Pablo de Lara @ 2022-11-07 9:58 UTC (permalink / raw)
To: brian.dooley; +Cc: dev, Pablo de Lara, marko.kovacevic, stable
Digest length is being printed out, not IV length.
Fixes: ac026f4668d0 ("examples/fips_validation: support CMAC parsing")
Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
Cc: marko.kovacevic@intel.com
Cc: stable@dpdk.org
---
examples/fips_validation/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 404a29d7b6..9a9babb53a 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1210,7 +1210,7 @@ prepare_hmac_xform(struct rte_crypto_sym_xform *xform)
if (rte_cryptodev_sym_capability_check_auth(cap,
auth_xform->key.length,
auth_xform->digest_length, 0) != 0) {
- RTE_LOG(ERR, USER1, "PMD %s key length %u IV length %u\n",
+ RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length %u\n",
info.device_name, auth_xform->key.length,
auth_xform->digest_length);
return -EPERM;
@@ -1339,7 +1339,7 @@ prepare_cmac_xform(struct rte_crypto_sym_xform *xform)
if (rte_cryptodev_sym_capability_check_auth(cap,
auth_xform->key.length,
auth_xform->digest_length, 0) != 0) {
- RTE_LOG(ERR, USER1, "PMD %s key length %u IV length %u\n",
+ RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length %u\n",
info.device_name, auth_xform->key.length,
auth_xform->digest_length);
return -EPERM;
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] examples/fips_validation: fix typo
2022-11-07 9:58 [PATCH] examples/fips_validation: fix typo Pablo de Lara
@ 2022-11-07 10:03 ` Pablo de Lara
2022-11-07 14:37 ` Dooley, Brian
0 siblings, 1 reply; 4+ messages in thread
From: Pablo de Lara @ 2022-11-07 10:03 UTC (permalink / raw)
To: brian.dooley; +Cc: dev, Pablo de Lara, marko.kovacevic, stable
Digest length is being printed out, not IV length.
Fixes: ac026f4668d0 ("examples/fips_validation: support CMAC parsing")
Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
Cc: marko.kovacevic@intel.com
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
-v2: added missing "Signed-off"
---
examples/fips_validation/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 404a29d7b6..9a9babb53a 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1210,7 +1210,7 @@ prepare_hmac_xform(struct rte_crypto_sym_xform *xform)
if (rte_cryptodev_sym_capability_check_auth(cap,
auth_xform->key.length,
auth_xform->digest_length, 0) != 0) {
- RTE_LOG(ERR, USER1, "PMD %s key length %u IV length %u\n",
+ RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length %u\n",
info.device_name, auth_xform->key.length,
auth_xform->digest_length);
return -EPERM;
@@ -1339,7 +1339,7 @@ prepare_cmac_xform(struct rte_crypto_sym_xform *xform)
if (rte_cryptodev_sym_capability_check_auth(cap,
auth_xform->key.length,
auth_xform->digest_length, 0) != 0) {
- RTE_LOG(ERR, USER1, "PMD %s key length %u IV length %u\n",
+ RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length %u\n",
info.device_name, auth_xform->key.length,
auth_xform->digest_length);
return -EPERM;
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] examples/fips_validation: fix typo
2022-11-07 10:03 ` [PATCH v2] " Pablo de Lara
@ 2022-11-07 14:37 ` Dooley, Brian
2022-11-08 5:20 ` Akhil Goyal
0 siblings, 1 reply; 4+ messages in thread
From: Dooley, Brian @ 2022-11-07 14:37 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, Kovacevic, Marko, stable
Hi Pablo,
> -----Original Message-----
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Sent: Monday, November 7, 2022 10:04 AM
> To: Dooley, Brian <brian.dooley@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Kovacevic, Marko <marko.kovacevic@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] examples/fips_validation: fix typo
>
> Digest length is being printed out, not IV length.
>
> Fixes: ac026f4668d0 ("examples/fips_validation: support CMAC parsing")
> Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
> Cc: marko.kovacevic@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> -v2: added missing "Signed-off"
> ---
>
> examples/fips_validation/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/fips_validation/main.c
> b/examples/fips_validation/main.c index 404a29d7b6..9a9babb53a 100644
> --- a/examples/fips_validation/main.c
> +++ b/examples/fips_validation/main.c
> @@ -1210,7 +1210,7 @@ prepare_hmac_xform(struct
> rte_crypto_sym_xform *xform)
> if (rte_cryptodev_sym_capability_check_auth(cap,
> auth_xform->key.length,
> auth_xform->digest_length, 0) != 0) {
> - RTE_LOG(ERR, USER1, "PMD %s key length %u IV length
> %u\n",
> + RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length
> %u\n",
> info.device_name, auth_xform->key.length,
> auth_xform->digest_length);
> return -EPERM;
> @@ -1339,7 +1339,7 @@ prepare_cmac_xform(struct
> rte_crypto_sym_xform *xform)
> if (rte_cryptodev_sym_capability_check_auth(cap,
> auth_xform->key.length,
> auth_xform->digest_length, 0) != 0) {
> - RTE_LOG(ERR, USER1, "PMD %s key length %u IV length
> %u\n",
> + RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length
> %u\n",
> info.device_name, auth_xform->key.length,
> auth_xform->digest_length);
> return -EPERM;
> --
> 2.34.1
Reviewed-by: Brian Dooley <brian.dooley@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] examples/fips_validation: fix typo
2022-11-07 14:37 ` Dooley, Brian
@ 2022-11-08 5:20 ` Akhil Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2022-11-08 5:20 UTC (permalink / raw)
To: Dooley, Brian, De Lara Guarch, Pablo; +Cc: dev, Kovacevic, Marko, stable
> > Subject: [PATCH v2] examples/fips_validation: fix typo
> >
> > Digest length is being printed out, not IV length.
> >
> > Fixes: ac026f4668d0 ("examples/fips_validation: support CMAC parsing")
> > Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
> > Cc: marko.kovacevic@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> Reviewed-by: Brian Dooley <brian.dooley@intel.com>
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-08 5:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 9:58 [PATCH] examples/fips_validation: fix typo Pablo de Lara
2022-11-07 10:03 ` [PATCH v2] " Pablo de Lara
2022-11-07 14:37 ` Dooley, Brian
2022-11-08 5:20 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).