DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eventdev: fix return value of null not checked
@ 2020-07-27 14:03 wangyunjian
  2020-08-06 15:40 ` Rao, Nikhil
  0 siblings, 1 reply; 3+ messages in thread
From: wangyunjian @ 2020-07-27 14:03 UTC (permalink / raw)
  To: dev, nikhil.rao; +Cc: jerry.lilijun, xudingke, Yunjian Wang, stable

From: Yunjian Wang <wangyunjian@huawei.com>

The function rte_zmalloc() could return NULL, the return value
need to be checked.

Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
index bb21dc407..86287b4e6 100644
--- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
@@ -734,6 +734,8 @@ txa_service_queue_add(uint8_t id,
 
 		qdone = rte_zmalloc(txa->mem_name,
 				nb_queues * sizeof(*qdone), 0);
+		if (qdone == NULL)
+			return -ENOMEM;
 		j = 0;
 		for (i = 0; i < nb_queues; i++) {
 			if (txa_service_is_queue_added(txa, eth_dev, i))
-- 
2.23.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked
  2020-07-27 14:03 [dpdk-dev] [PATCH] eventdev: fix return value of null not checked wangyunjian
@ 2020-08-06 15:40 ` Rao, Nikhil
  2020-10-04 10:02   ` Jerin Jacob
  0 siblings, 1 reply; 3+ messages in thread
From: Rao, Nikhil @ 2020-08-06 15:40 UTC (permalink / raw)
  To: wangyunjian, dev; +Cc: jerry.lilijun, xudingke, stable


> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Monday, July 27, 2020 7:33 PM
> To: dev@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>
> Cc: jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang
> <wangyunjian@huawei.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked
> 
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> The function rte_zmalloc() could return NULL, the return value need to be
> checked.
> 
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
>  lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> index bb21dc407..86287b4e6 100644
> --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> @@ -734,6 +734,8 @@ txa_service_queue_add(uint8_t id,
> 
>  		qdone = rte_zmalloc(txa->mem_name,
>  				nb_queues * sizeof(*qdone), 0);
> +		if (qdone == NULL)
> +			return -ENOMEM;

Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>

>  		j = 0;
>  		for (i = 0; i < nb_queues; i++) {
>  			if (txa_service_is_queue_added(txa, eth_dev, i))
> --
> 2.23.0
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked
  2020-08-06 15:40 ` Rao, Nikhil
@ 2020-10-04 10:02   ` Jerin Jacob
  0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2020-10-04 10:02 UTC (permalink / raw)
  To: Rao, Nikhil; +Cc: wangyunjian, dev, jerry.lilijun, xudingke, stable

On Thu, Aug 6, 2020 at 9:10 PM Rao, Nikhil <nikhil.rao@intel.com> wrote:
>
>
> > -----Original Message-----
> > From: wangyunjian <wangyunjian@huawei.com>
> > Sent: Monday, July 27, 2020 7:33 PM
> > To: dev@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>
> > Cc: jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang
> > <wangyunjian@huawei.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked
> >
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > The function rte_zmalloc() could return NULL, the return value need to be
> > checked.
> >
> > Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > ---
> >  lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> > b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> > index bb21dc407..86287b4e6 100644
> > --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> > +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
> > @@ -734,6 +734,8 @@ txa_service_queue_add(uint8_t id,
> >
> >               qdone = rte_zmalloc(txa->mem_name,
> >                               nb_queues * sizeof(*qdone), 0);
> > +             if (qdone == NULL)
> > +                     return -ENOMEM;
>
> Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>


Applied to dpdk-next-eventdev/for-main. Thanks.


>
> >               j = 0;
> >               for (i = 0; i < nb_queues; i++) {
> >                       if (txa_service_is_queue_added(txa, eth_dev, i))
> > --
> > 2.23.0
> >
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-04 10:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 14:03 [dpdk-dev] [PATCH] eventdev: fix return value of null not checked wangyunjian
2020-08-06 15:40 ` Rao, Nikhil
2020-10-04 10:02   ` Jerin Jacob

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git