From: "Shetty, Praveen" <praveen.shetty@intel.com>
To: Anoob Joseph <anoobj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue
Date: Wed, 6 May 2020 10:40:20 +0000 [thread overview]
Message-ID: <CY4PR1101MB23261DBE5E16B12F9E5C5EF89DA40@CY4PR1101MB2326.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN2PR18MB28779F47DA5B2E32524D4D05DFA40@MN2PR18MB2877.namprd18.prod.outlook.com>
Hi Anoob,
Thank you.
I have modified the commit message and headline accordingly and sent v2.
Regards,
Praveen
-----Original Message-----
From: Anoob Joseph <anoobj@marvell.com>
Sent: Wednesday, May 6, 2020 3:13 PM
To: Shetty, Praveen <praveen.shetty@intel.com>; dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>
Subject: RE: [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue
Hi Praveen,
Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: Praveen Shetty <praveen.shetty@intel.com>
> Sent: Wednesday, May 6, 2020 2:33 PM
> To: dev@dpdk.org; declan.doherty@intel.com; akhil.goyal@nxp.com; Anoob
> Joseph <anoobj@marvell.com>
> Cc: bernard.iremonger@intel.com; konstantin.ananyev@intel.com;
> praveen.shetty@intel.com
> Subject: [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue
[Anoob] I believe Thomas insists on explaining the issue that you are trying to fix rather than stating "resolve coverity issue" (which is too generic). So I guess you can remove all such references to coverity and retain rest of your description.
>
> External Email
>
> ----------------------------------------------------------------------
> Function create_ipsec_esp_flow returns a negative number in case of
> any failure. But passing negative number to strerror is causing the coverity issue.
> In case of failure, displaying exact error message to console is
> handled in create_ipsec_esp_flow function.So it is not required to
> print the error message again using strerror.
> This patch will remove the unnecessary calling of strerror function to
> fix the coverity issue.
>
> Coverity issue: 357691
> Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director")
> Cc: praveen.shetty@intel.com
>
> Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> ---
> examples/ipsec-secgw/sa.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index
> e3a1a5aff..632482176 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct
> ipsec_sa entries[],
> rc = create_ipsec_esp_flow(sa);
> if (rc != 0)
> RTE_LOG(ERR, IPSEC_ESP,
> - "create_ipsec_esp_flow() failed %s\n",
> - strerror(rc));
> + "create_ipsec_esp_flow() failed\n");
> }
> print_one_sa_rule(sa, inbound);
> }
> --
> 2.17.1
next prev parent reply other threads:[~2020-05-06 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200506090256eucas1p1c4457861c66c164d46000835709ccd84@eucas1p1.samsung.com>
2020-05-06 9:02 ` [dpdk-dev] " Praveen Shetty
2020-05-06 9:37 ` Lukasz Wojciechowski
2020-05-06 9:43 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-05-06 10:40 ` Shetty, Praveen [this message]
2020-05-06 10:37 ` [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix negative argument passing Praveen Shetty
2020-05-06 10:50 ` Lukasz Wojciechowski
2020-05-06 11:03 ` Shetty, Praveen
2020-05-06 11:45 ` Lukasz Wojciechowski
2020-05-06 11:02 ` [dpdk-dev] [PATCH v3] " Praveen Shetty
2020-05-07 4:18 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-05-09 22:02 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1101MB23261DBE5E16B12F9E5C5EF89DA40@CY4PR1101MB2326.namprd11.prod.outlook.com \
--to=praveen.shetty@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=bernard.iremonger@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).