From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl
Date: Sun, 28 Oct 2018 12:53:42 +0000 [thread overview]
Message-ID: <DB7PR05MB4426A49992313ECC66434D20C3F20@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20181026214852.GB13615@mtidpdk.mti.labs.mlnx>
Saturday, October 27, 2018 12:49 AM, Yongseok Koh:
> Subject: Re: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE
> libmnl
>
> On Thu, Oct 25, 2018 at 01:29:38PM -0700, Stephen Hemminger wrote:
> > SUSE decided to install the libmnl include file in a non-standard
> > place: /usr/include/libmnl/libmnl/libmnl.h
> >
> > This was probably a mistake by the SUSE package maintainer, but hard
> > to get fixed. Workaround the problem by pkg-config to find the
> > necessary include directive for libmnl.
> >
> > Fixes: 20b71e92ef8e ("net/mlx5: lay groundwork for switch offloads")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, with addition of Cc:stable@dpdk.org. thanks.
>
> Thanks
>
> > v3 - Tested on SLES 15, needs $(shell pkg-config ...)
> >
> > drivers/net/mlx5/Makefile | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> > index 1e9c0b42ac16..8497c98ef86e 100644
> > --- a/drivers/net/mlx5/Makefile
> > +++ b/drivers/net/mlx5/Makefile
> > @@ -51,6 +51,7 @@ CFLAGS += -D_DEFAULT_SOURCE CFLAGS +=
> > -D_XOPEN_SOURCE=600 CFLAGS += $(WERROR_FLAGS) CFLAGS +=
> > -Wno-strict-prototypes
> > +CFLAGS += $(shell pkg-config --cflags libmnl)
> > ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y)
> > CFLAGS += -DMLX5_GLUE='"$(LIB_GLUE)"'
> > CFLAGS += -DMLX5_GLUE_VERSION='"$(LIB_GLUE_VERSION)"'
> > @@ -59,7 +60,7 @@ LDLIBS += -ldl
> > else
> > LDLIBS += -libverbs -lmlx5
> > endif
> > -LDLIBS += -lmnl
> > +LDLIBS += $(shell pkg-config --libs libmnl)
> > LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS +=
> > -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_bus_pci
> > --
> > 2.19.1
> >
prev parent reply other threads:[~2018-10-28 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 20:29 Stephen Hemminger
2018-10-26 21:49 ` Yongseok Koh
2018-10-28 12:53 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB4426A49992313ECC66434D20C3F20@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).