Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

[Shahaf Shuler <shahafs@mellanox.com>]

Tuesday, June 26, 2018 4:39 PM, Ferruh Yigit:
> Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to
> simulate a noisy neighbour
> 
> On 6/26/2018 1:17 PM, Shahaf Shuler wrote:
> > HI Maxime, Jens
> >
> > Saturday, June 23, 2018 11:09 AM, Maxime Coquelin:
> >> Subject: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to
> >> simulate a noisy neighbour
> >>
> >> From: Jens Freimann <jfreimann@redhat.com>
> >>
> >> This adds a new forwarding mode to testpmd to simulate more realistic
> >> behavior of a guest machine engaged in receiving and sending packets
> >> performing Virtual Network Function (VNF).
> >
> > I really like the idea of adding application w/ more realistic behavior to the
> DPDK tree in order to use them in the non-regression cycle.
> >
> > I am just wondering if putting it as another forward engine in testpmd is
> the right place for it.
> 
> Hi Shahaf,
> 
> This was the request in old review comments. As you said it is good to have
> more realistic behavior but also we would like to test/use io forwarding, so
> new forwarding engine is way of having both two.

Sorry, I missed reading the previous comments. 
As I said, there are upsides and downsides to it. I still think it deserve a separate example but we can start inside testpmd and move it to other location when needed.