From: Shahaf Shuler <shahafs@mellanox.com> To: Yongseok Koh <yskoh@mellanox.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "roszenrami@gmail.com" <roszenrami@gmail.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "stable@dpdk.org" <stable@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Date: Thu, 10 Jan 2019 19:10:04 +0000 Message-ID: <DB7PR05MB4426EBCE0B4B424A504CA78CC3840@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw) In-Reply-To: <20190110183528.42503-2-yskoh@mellanox.com> Thursday, January 10, 2019 8:35 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on > replenishing Rx buffer > > On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed to > be accessed as it is static and easily calculated from the mbuf address. > Accessing the mbuf content causes unnecessary load stall and it is worsened on > ARM. > > Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SSE Rx") > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> Acked-by: Shahaf Shuler <shahafs@mellanox.com> > --- > > v3: > * rte_mbuf_buf_addr_default() -> rte_mbuf_buf_addr() > > v2: > * use the newly introduced API - rte_mbuf_buf_addr_default() > * fix error in assert > > drivers/net/mlx5/mlx5_rxtx_vec.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec.h > b/drivers/net/mlx5/mlx5_rxtx_vec.h > index fda7004e2d..989a1fdce5 100644 > --- a/drivers/net/mlx5/mlx5_rxtx_vec.h > +++ b/drivers/net/mlx5/mlx5_rxtx_vec.h > @@ -102,8 +102,10 @@ mlx5_rx_replenish_bulk_mbuf(struct mlx5_rxq_data > *rxq, uint16_t n) > return; > } > for (i = 0; i < n; ++i) { > - wq[i].addr = rte_cpu_to_be_64((uintptr_t)elts[i]->buf_addr + > - RTE_PKTMBUF_HEADROOM); > + void *buf_addr = rte_mbuf_buf_addr(elts[i], rxq->mp); > + > + assert(buf_addr == elts[i]->buf_addr); > + wq[i].addr = rte_cpu_to_be_64((uintptr_t)buf_addr + > +RTE_PKTMBUF_HEADROOM); > /* If there's only one MR, no need to replace LKey in WQE. */ > if (unlikely(mlx5_mr_btree_len(&rxq->mr_ctrl.cache_bh) > 1)) > wq[i].lkey = mlx5_rx_mb2mr(rxq, elts[i]); > -- > 2.11.0
next prev parent reply other threads:[~2019-01-10 19:10 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-09 8:54 [dpdk-dev] [PATCH] " Yongseok Koh 2019-01-09 9:38 ` David Marchand 2019-01-09 9:52 ` Olivier Matz 2019-01-09 9:56 ` Yongseok Koh 2019-01-09 10:05 ` David Marchand 2019-01-09 10:11 ` Yongseok Koh 2019-01-09 13:19 ` [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address Yongseok Koh 2019-01-09 13:19 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-09 13:46 ` [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address David Marchand 2019-01-10 1:39 ` Rami Rosen 2019-01-10 18:18 ` Yongseok Koh 2019-01-10 18:22 ` Yongseok Koh 2019-01-10 18:35 ` [dpdk-dev] [PATCH v3 " Yongseok Koh 2019-01-10 18:35 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-10 19:10 ` Shahaf Shuler [this message] 2019-01-11 8:14 ` [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address Andrew Rybchenko 2019-01-11 11:03 ` Yongseok Koh 2019-01-11 11:17 ` Andrew Rybchenko 2019-01-11 11:37 ` Yongseok Koh 2019-01-11 11:57 ` Bruce Richardson 2019-01-11 12:48 ` David Marchand 2019-01-14 15:51 ` Olivier Matz 2019-01-10 22:40 ` [dpdk-dev] [PATCH v4 " Yongseok Koh 2019-01-10 22:40 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-11 8:05 ` [dpdk-dev] [PATCH v4 1/2] mbuf: add function returning default buffer address Olivier Matz 2019-01-11 8:11 ` David Marchand 2019-01-11 8:32 ` David Marchand 2019-01-11 11:09 ` Yongseok Koh 2019-01-11 10:25 ` Thomas Monjalon 2019-01-14 21:16 ` [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning " Yongseok Koh 2019-01-14 21:16 ` [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-02-06 15:54 ` Kevin Traynor 2019-02-21 19:10 ` Kevin Traynor 2019-03-08 2:05 ` Yongseok Koh 2019-01-15 1:35 ` [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning buffer address Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB7PR05MB4426EBCE0B4B424A504CA78CC3840@DB7PR05MB4426.eurprd05.prod.outlook.com \ --to=shahafs@mellanox.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=olivier.matz@6wind.com \ --cc=roszenrami@gmail.com \ --cc=stable@dpdk.org \ --cc=yskoh@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git