DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Shijith Thotton <shijith.thotton@gmail.com>
Cc: Shijith Thotton <sthotton@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
	Akhil Goyal <gakhil@marvell.com>,
	"Anoob Joseph" <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service
Date: Wed, 14 Apr 2021 07:06:15 +0000
Message-ID: <DM6PR11MB3548889F44BB2542828A53B6E84E9@DM6PR11MB3548.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210413075124.GA21@BG-LT7405.marvell.com>



> -----Original Message-----
> From: Shijith Thotton <shijith.thotton@gmail.com>
> Sent: Tuesday, April 13, 2021 1:21 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Jerin Jacob
> <jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>
> Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto
> adapter service
> 
> On Tue, Apr 13, 2021 at 04:08:40AM +0000, Gujjar, Abhinandan S wrote:
> >
> >
> > > -----Original Message-----
> > > From: Shijith Thotton <sthotton@marvell.com>
> > > Sent: Monday, April 12, 2021 2:24 PM
> > > To: dev@dpdk.org
> > > Cc: Shijith Thotton <sthotton@marvell.com>; Gujjar, Abhinandan S
> > > <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> > > Akhil Goyal <gakhil@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>
> > > Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter
> > > service
> > >
> > > Initiate software crypto adapter service, only if hardware
> > > capabilities are not reported. In OP_FORWARD mode, software service
> > > is not required to enqueue events if OP_FORWARD capability is
> supported by the PMD.
> > >
> > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
> > >
> > > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> > > ---
> > > v2:
> > > - Reworded commit message.
> > >
> > >  lib/librte_eventdev/rte_event_crypto_adapter.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c
> > > b/lib/librte_eventdev/rte_event_crypto_adapter.c
> > > index d903cdd48..e1d38d383 100644
> > > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c
> > > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
> > > @@ -861,6 +861,7 @@
> rte_event_crypto_adapter_queue_pair_add(uint8_t
> > > id,
> > >  	 *          b. OP_NEW mode -> SW Dequeue
> > >  	 */
> > >  	if ((cap &
> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&
> > > +	     !(cap &
> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> > The same check is below ORed with above condition.
> > This is confusing. Could you recheck & do the necessary changes?
> >
> 
> As per comments above, below checks are used to initiate SW service if:
> 1. PMDs supports OP_NEW, but not OP_FWD, in FWD mode.
> 2. Does not support OP_NEW and OP_FWD.
> 
> I have fixed the first point where only support for OP_NEW is checked in
> forward mode, by adding a check for no OP_FWD capability.
Sounds good.

Acked-by: Abhinandan.gujjar@intel.com

> 
> > >  	     adapter->mode ==
> > > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) ||
> > >  	     (!(cap &
> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) &&
> > >  	      !(cap &
> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> > > --
> > > 2.25.1
> >

  reply	other threads:[~2021-04-14  7:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  7:08 [dpdk-dev] [PATCH v1] " Shijith Thotton
2021-04-12  7:30 ` Jerin Jacob
2021-04-12  8:53 ` [dpdk-dev] [PATCH v2] " Shijith Thotton
2021-04-13  4:08   ` Gujjar, Abhinandan S
2021-04-13  7:51     ` Shijith Thotton
2021-04-14  7:06       ` Gujjar, Abhinandan S [this message]
2021-04-17 17:24         ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3548889F44BB2542828A53B6E84E9@DM6PR11MB3548.namprd11.prod.outlook.com \
    --to=abhinandan.gujjar@intel.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=shijith.thotton@gmail.com \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git