From: "Peng, Yuan" <yuan.peng@intel.com>
To: "Rong, Leyi" <leyi.rong@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Rong, Leyi" <leyi.rong@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured
Date: Wed, 20 May 2020 07:56:34 +0000 [thread overview]
Message-ID: <DM6PR11MB3898D4BD8D8A6B02741D9F60FEB60@DM6PR11MB3898.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200520063950.50315-1-leyi.rong@intel.com>
Test-by Peng, Yuan <yuan.peng@intel.com>
-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Leyi Rong
Sent: Wednesday, May 20, 2020 2:40 PM
To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
Subject: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured
FDIR ID parsing will not be handled correctly after queue reconfigured, enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it.
Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value")
Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
drivers/net/iavf/iavf_rxtx.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 73968847f..59625a979 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on) {
if (on) {
/* enable flow director processing */
- if (ad->fdir_ref_cnt++ == 0)
- FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+ FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+ ad->fdir_ref_cnt++;
} else {
if (ad->fdir_ref_cnt >= 1) {
ad->fdir_ref_cnt--;
--
2.17.1
prev parent reply other threads:[~2020-05-20 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 6:39 Leyi Rong
2020-05-20 7:10 ` Ye Xiaolong
2020-05-20 7:56 ` Peng, Yuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3898D4BD8D8A6B02741D9F60FEB60@DM6PR11MB3898.namprd11.prod.outlook.com \
--to=yuan.peng@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=leyi.rong@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).