RE: [EXT] [PATCH v2] common/qat: enable QAT 2.0c devices

["Power, Ciara" <ciara.power@intel.com>]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, September 19, 2023 6:50 AM
> To: Power, Ciara <ciara.power@intel.com>; dev@dpdk.org
> Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>;
> david.marchand@redhat.com; Ji, Kai <kai.ji@intel.com>
> Subject: RE: [EXT] [PATCH v2] common/qat: enable QAT 2.0c devices
> 
> 
> > This commit enables QAT 2.0c devices in the Intel QuickAssist
> > Technology PMD.
> > These are 4th Generation QAT, 402xx devices.
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> >
> > ---
> > v2:
> >   - Fixed kernel module.
> >   - Modified commit to align naming of new QAT device.
> > ---
> >  doc/guides/cryptodevs/qat.rst          | 4 ++++
> >  doc/guides/rel_notes/release_23_11.rst | 4 ++++
> >  drivers/common/qat/qat_device.c        | 4 ++++
> >  3 files changed, 12 insertions(+)
> >
> > diff --git a/doc/guides/cryptodevs/qat.rst
> > b/doc/guides/cryptodevs/qat.rst index afdfb0bd22..730113da33 100644
> > --- a/doc/guides/cryptodevs/qat.rst
> > +++ b/doc/guides/cryptodevs/qat.rst
> > @@ -457,6 +457,10 @@ to see the full table)
> >
> > +-----+-----+-----+-----+----------+---------------+---------------+--
> > ----------+--------
> > +------+--------+--------+
> >     | Yes | No  | No  | 4   | 401xxx   | IDZ/ N/A      | qat_401xxx    | 4xxx       |
> 4942
> > | 2    | 4943   | 16     |
> >
> > +-----+-----+-----+-----+----------+---------------+---------------+--
> > ----------+--------
> > +------+--------+--------+
> > +   | Yes | Yes | Yes | 4   | 402xx    | linux/6.4+    | qat_4xxx      | 4xxx       | 4944
> > | 2    | 4945   | 16     |
> > +
> > + +-----+-----+-----+-----+----------+---------------+---------------+
> > + ------------+--------
> > +------+--------+--------+
> > +   | Yes | No  | No  | 4   | 402xx    | IDZ/ N/A      | qat_4xxx      | 4xxx       |
> 4944
> > | 2    | 4945   | 16     |
> > +
> > + +-----+-----+-----+-----+----------+---------------+---------------+
> > + ------------+--------
> > +------+--------+--------+
> >
> >  * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only
> > with IDZ driver version 4.9.0+
> >
> > diff --git a/doc/guides/rel_notes/release_23_11.rst
> > b/doc/guides/rel_notes/release_23_11.rst
> > index 4411bb32c1..72dfb3fbf0 100644
> > --- a/doc/guides/rel_notes/release_23_11.rst
> > +++ b/doc/guides/rel_notes/release_23_11.rst
> > @@ -72,6 +72,10 @@ New Features
> >       Also, make sure to start the actual text at the margin.
> >       =======================================================
> >
> > +* **Added support for QAT 2.0c devices to Intel QuickAssist
> > +Technology
> > PMD.**
> > +
> > +  * QAT 2.0c (4944) devices are now enabled for QAT.
> 
> Is it 4944 or 4945? In the code below, the PCI device added is 4945

The device PF ID is 4944, but the corresponding VF ID used in DPDK for the device is 4945.

Thanks,
Ciara