From: "Zhang, Helin" <helin.zhang@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table Date: Thu, 6 Nov 2014 08:52:55 +0000 Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7AF5D9@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <3931991.XHvGI58gnD@xps13> > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 6, 2014 4:33 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of > redirection table > > 2014-11-06 01:02, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-31 17:03, Helin Zhang: > > > > #define ETH_RSS_RETA_SIZE_64 64 > > > > #define ETH_RSS_RETA_SIZE_128 128 #define ETH_RSS_RETA_SIZE_512 > > > > 512 > > > > > > Are these values still needed? > > > > It was widely used in igb/ixgbe/i40e code, and app/testpmd. It is good > > to be kept there, though we can define them separately in each > > component. This would be more convenient for PMDs and user applications. > > If it should be used by applications, it must stay in ethdev. Good to get it aligned with us. > > > > Why 256 is forbidden? > > > > 256 is not a valid table size of current supported NICs, for > > other/future NIC which supports this size, it can be added later as needed. > > The problem is that we don't know which value is supported for each driver. > You should add a comment like this: > /**@{ > * Some RSS RETA sizes may be not supported by some drivers. > * Check in the PMD documentation. > */ > #define ETH_RSS_RETA_SIZE_64 64 > #define ETH_RSS_RETA_SIZE_128 128 > #define ETH_RSS_RETA_SIZE_512 512 > /**@}*/ In rte_ethdev.h, there is comments for rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query() that the reta table size can be queried by rte_eth_dev_info_get(). So the end users could know the reta size of each NIC by reading its datasheet, or call that function to query the size directly. The macros defined here let the reta size more straightforward, and easy to use. OK, it is good to add some annotations here. Thanks! > > And then add some comments in the PMD to describe the supported sizes. > > > > Maybe that some comments are needed here. > > > > Comments might not be needed, as their names tell us what they are > > clearly. Did you mean any other annotations to be added for these > > macros? I am open for that to add any good annotations for them. > > We just have to keep in mind that the API reference for users is in doxygen. > Some details are obvious for you but not clear for the user, especially if he > doesn't care about i40e. > > Thanks > -- > Thomas Regards, Helin
next prev parent reply other threads:[~2014-11-06 8:45 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-25 8:40 [dpdk-dev] [PATCH v2 00/13] " Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 01/13] app/testpmd: code style fix Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 02/13] i40evf: " Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 03/13] ethdev: add more annotation Helin Zhang 2014-10-21 20:38 ` Thomas Monjalon 2014-10-21 22:20 ` Zhang, Helin 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-10-21 20:53 ` Thomas Monjalon 2014-10-28 0:33 ` Zhang, Helin 2014-10-28 10:10 ` Thomas Monjalon 2014-10-28 10:18 ` Richardson, Bruce 2014-10-28 13:20 ` Zhang, Helin 2014-10-28 14:22 ` Thomas Monjalon 2014-10-29 8:18 ` Zhang, Helin 2014-10-28 12:00 ` Zhang, Helin 2014-10-28 12:13 ` Thomas Monjalon 2014-10-28 12:36 ` Zhang, Helin 2014-10-29 8:24 ` Zhang, Helin 2014-10-29 10:00 ` Thomas Monjalon 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 05/13] igb: add new function for VF ops of 'dev_infos_get' Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 06/13] igb: rework of updating/querying reta Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 07/13] ixgbe: add new function for VF ops of 'dev_infos_get' Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 08/13] ixgbe: rework of updating/querying reta Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 09/13] i40e: support of setting hash lookup table size Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 10/13] i40e: support of getting redirection " Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 11/13] i40e: rework of updating/querying reta Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 12/13] i40evf: support of updating/querying redirection table Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 13/13] app/testpmd: rework of commands for updating/querying reta Helin Zhang 2014-10-10 3:11 ` [dpdk-dev] [PATCH v2 00/13] support of multiple sizes of redirection table Liang, Cunming 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 0/8] " Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 1/8] app/testpmd: code style fix Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 2/8] i40evf: " Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 3/8] i40e: support of setting hash lookup table size Helin Zhang 2014-10-27 14:13 ` Thomas Monjalon 2014-10-27 20:21 ` Matthew Hall 2014-10-27 21:41 ` Thomas Monjalon 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 5/8] ixgbe: " Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-10-27 14:23 ` Thomas Monjalon 2014-10-28 0:37 ` Zhang, Helin 2014-10-28 10:04 ` Thomas Monjalon 2014-10-31 1:39 ` Zhang, Helin 2014-10-31 8:46 ` Thomas Monjalon 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 8/8] i40evf: support of updating/querying " Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 0/8] support of multiple sizes of " Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 1/8] app/testpmd: code style fix Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 2/8] i40evf: " Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 3/8] i40e: support of setting hash lookup table size Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 5/8] ixgbe: " Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-11-05 20:52 ` Thomas Monjalon 2014-11-06 1:02 ` Zhang, Helin 2014-11-06 8:33 ` Thomas Monjalon 2014-11-06 8:52 ` Zhang, Helin [this message] 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 8/8] i40evf: support of updating/querying " Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 0/8] support of multiple sizes of " Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 1/8] app/testpmd: code style fix Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 2/8] i40evf: " Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 3/8] i40e: support of setting hash lookup table size Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 5/8] ixgbe: " Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 7/8] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 8/8] i40evf: support of updating/querying " Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 0/8] support of multiple sizes of " Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 1/8] app/testpmd: code style fix Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 2/8] i40evf: " Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 3/8] i40e: support of setting hash lookup table size Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 5/8] ixgbe: " Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 7/8] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 8/8] i40evf: support of updating/querying " Helin Zhang 2014-11-24 22:20 ` Thomas Monjalon 2014-11-25 0:28 ` Zhang, Helin 2014-11-17 13:39 ` [dpdk-dev] [PATCH v6 0/8] support of multiple sizes of " Ananyev, Konstantin 2014-11-24 22:00 ` Thomas Monjalon 2014-11-19 9:28 ` Chen, Erlu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A7AF5D9@SHSMSX104.ccr.corp.intel.com \ --to=helin.zhang@intel.com \ --cc=dev@dpdk.org \ --cc=thomas.monjalon@6wind.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git