From: "Zhang, Helin" <helin.zhang@intel.com>
To: Alex Gartrell <agartrell@fb.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL
Date: Tue, 24 Mar 2015 01:03:05 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A830343@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1426274503-372191-1-git-send-email-agartrell@fb.com>
Hi Alex
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alex Gartrell
> Sent: Saturday, March 14, 2015 3:22 AM
> To: dev@dpdk.org
> Cc: kernel-team@fb.com
> Subject: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL
>
> I couldn't figure out why this #ifdef existed so I looked around upstream and it's
> not there. It seems to build just fine without it.
You can see in igb/kcomat.h of below code section.
#ifndef CONFIG_BQL
#define netdev_tx_completed_queue(_q, _p, _b) do {} while (0)
#define netdev_completed_queue(_n, _p, _b) do {} while (0)
#define netdev_tx_sent_queue(_q, _b) do {} while (0)
#define netdev_sent_queue(_n, _b) do {} while (0)
#define netdev_tx_reset_queue(_q) do {} while (0)
#define netdev_reset_queue(_n) do {} while (0)
#endif
That means all callers of txring_txq() are conditional compiled. I don't think your
modifications are needed.
Regards,
Helin
>
> Signed-off-by: Alex Gartrell <agartrell@fb.com>
> ---
> lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> index a582f52..d58e1f3 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> @@ -472,12 +472,10 @@ static inline u16 igb_desc_unused(const struct
> igb_ring *ring)
> return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1; }
>
> -#ifdef CONFIG_BQL
> static inline struct netdev_queue *txring_txq(const struct igb_ring *tx_ring)
> {
> return netdev_get_tx_queue(tx_ring->netdev, tx_ring->queue_index); }
> -#endif /* CONFIG_BQL */
>
> // #ifdef EXT_THERMAL_SENSOR_SUPPORT
> // #ifdef IGB_PROCFS
> --
> Alex Gartrell <agartrell@fb.com>
prev parent reply other threads:[~2015-03-24 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 19:21 Alex Gartrell
2015-03-23 11:27 ` Thomas Monjalon
2015-03-24 1:03 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A830343@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=agartrell@fb.com \
--cc=dev@dpdk.org \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
DPDK patches and discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
dev@dpdk.org
public-inbox-index dev
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git