From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"chas3@att.com" <chas3@att.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and transmit
Date: Sat, 13 Jan 2018 06:33:58 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ACFC83C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1515658974-63940-1-git-send-email-wenzhuo.lu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Thursday, January 11, 2018 4:23 PM
> To: chas3@att.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and
> transmit
>
> Hi,
>
> > Date: Thu, 19 Oct 2017 23:23:39 -0400
> >
> > From: Chas Williams <chas3@att.com>
> >
> > The transmit and receive controller state machines are only enabled
> > after receiving an interrupt and the link status is now valid. If an
> > adapter is being used in conjunction with NC-SI, network controller
> > sideband interface, the adapter may never get a link state change
> > interrupt since the adapter's PHY is always link up and never changes state.
> >
> > To fix this, always enable and disable the transmit and receive with
> > .dev_start and .dev_stop. This is a better match for what is
> > typically done with the other PMD's. Since we may never get an
> > interrupt to check the link state, we also poll once at the end of
> > .dev_start to get the current link status.
> >
> > Signed-off-by: Chas Williams <chas3@att.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
prev parent reply other threads:[~2018-01-13 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 19:18 [dpdk-dev] [PATCH] " Charles (Chas) Williams
2017-07-18 11:50 ` Ferruh Yigit
2017-10-20 3:23 ` [dpdk-dev] [PATCH v2] " Chas Williams
2018-01-11 8:22 ` [dpdk-dev] [dpdk-dev, " Wenzhuo Lu
2018-01-13 6:33 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71ACFC83C@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).