* [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency
@ 2020-07-13 13:51 Ferruh Yigit
2020-07-13 15:46 ` Ruifeng Wang
2020-07-15 11:16 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-07-13 13:51 UTC (permalink / raw)
To: Honnappa Nagarahalli, Ruifeng Wang, Vladimir Medvedkin, Ray Kinsella
Cc: dev, Ferruh Yigit
'librte_rcu' is now dependency to 'librte_lpm' library, this dependency
should be reflected to build system.
Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: ruifeng.wang@arm.com
---
lib/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Makefile b/lib/Makefile
index 4b981f505e..8f5b68a2d4 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib
DEPDIRS-librte_fib := librte_eal librte_rib
DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm
-DEPDIRS-librte_lpm := librte_eal librte_hash
+DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl
DEPDIRS-librte_acl := librte_eal
DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
--
2.25.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency
2020-07-13 13:51 [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency Ferruh Yigit
@ 2020-07-13 15:46 ` Ruifeng Wang
2020-07-14 11:20 ` Kinsella, Ray
2020-07-15 11:16 ` David Marchand
1 sibling, 1 reply; 4+ messages in thread
From: Ruifeng Wang @ 2020-07-13 15:46 UTC (permalink / raw)
To: Ferruh Yigit, Honnappa Nagarahalli, Vladimir Medvedkin, Ray Kinsella
Cc: dev, nd
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, July 13, 2020 9:51 PM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Vladimir Medvedkin
> <vladimir.medvedkin@intel.com>; Ray Kinsella <mdr@ashroe.eu>
> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [PATCH] lib: fix build for missing RCU library dependency
>
> 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should
> be reflected to build system.
>
> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: ruifeng.wang@arm.com
Hi Ferruh,
Thanks for fixing this.
Although I didn't reproduce the building issue, this patch is obviously valid.
Regards.
/Ruifeng
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Makefile b/lib/Makefile index 4b981f505e..8f5b68a2d4 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
> DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib DEPDIRS-librte_fib :=
> librte_eal librte_rib
> DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm -DEPDIRS-librte_lpm :=
> librte_eal librte_hash
> +DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
> DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl DEPDIRS-librte_acl :=
> librte_eal
> DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
> --
> 2.25.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency
2020-07-13 15:46 ` Ruifeng Wang
@ 2020-07-14 11:20 ` Kinsella, Ray
0 siblings, 0 replies; 4+ messages in thread
From: Kinsella, Ray @ 2020-07-14 11:20 UTC (permalink / raw)
To: Ruifeng Wang, Ferruh Yigit, Honnappa Nagarahalli, Vladimir Medvedkin
Cc: dev, nd
On 13/07/2020 16:46, Ruifeng Wang wrote:
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, July 13, 2020 9:51 PM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
>> <Ruifeng.Wang@arm.com>; Vladimir Medvedkin
>> <vladimir.medvedkin@intel.com>; Ray Kinsella <mdr@ashroe.eu>
>> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
>> Subject: [PATCH] lib: fix build for missing RCU library dependency
>>
>> 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should
>> be reflected to build system.
>>
>> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: ruifeng.wang@arm.com
> Hi Ferruh,
>
> Thanks for fixing this.
> Although I didn't reproduce the building issue, this patch is obviously valid.
>
> Regards.
> /Ruifeng
>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Was already there for meson/ninja.
Acked-by: Ray Kinsella <mdr@ashroe.eu>
>> ---
>> lib/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Makefile b/lib/Makefile index 4b981f505e..8f5b68a2d4 100644
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
>> DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib DEPDIRS-librte_fib :=
>> librte_eal librte_rib
>> DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm -DEPDIRS-librte_lpm :=
>> librte_eal librte_hash
>> +DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
>> DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl DEPDIRS-librte_acl :=
>> librte_eal
>> DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
>> --
>> 2.25.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency
2020-07-13 13:51 [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency Ferruh Yigit
2020-07-13 15:46 ` Ruifeng Wang
@ 2020-07-15 11:16 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-07-15 11:16 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Honnappa Nagarahalli, Ruifeng Wang, Vladimir Medvedkin,
Ray Kinsella, dev
On Mon, Jul 13, 2020 at 3:51 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency
> should be reflected to build system.
Good catch, thanks Ferruh.
> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
Applied.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-15 11:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 13:51 [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency Ferruh Yigit
2020-07-13 15:46 ` Ruifeng Wang
2020-07-14 11:20 ` Kinsella, Ray
2020-07-15 11:16 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).