DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Stokes, Ian" <ian.stokes@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/4] examples/vhost: remove dequeue zero-copy support
Date: Wed, 23 Sep 2020 05:43:50 +0000
Message-ID: <MN2PR11MB4063799CF9B4EE8CC8D34B399C380@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200915133558.210639-4-maxime.coquelin@redhat.com>

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, September 15, 2020 9:36 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Stokes, Ian
> <ian.stokes@intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH 3/4] examples/vhost: remove dequeue zero-copy support
> 
> Dequeue zero-copy feature is being removed from the
> Vhost library. This preliminary patch removes its uses
> in the Vhost example application.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  examples/vhost/main.c | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index e1578e7956..959c0c2838 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -92,7 +92,6 @@ static uint32_t enable_tx_csum;
>  static uint32_t enable_tso;
> 
>  static int client_mode;
> -static int dequeue_zero_copy;
> 
>  static int builtin_net_driver;
> 
> @@ -247,16 +246,6 @@ port_init(uint16_t port)
>  	rx_ring_size = RTE_TEST_RX_DESC_DEFAULT;
>  	tx_ring_size = RTE_TEST_TX_DESC_DEFAULT;
> 
> -	/*
> -	 * When dequeue zero copy is enabled, guest Tx used vring will be
> -	 * updated only when corresponding mbuf is freed. Thus, the
> nb_tx_desc
> -	 * (tx_ring_size here) must be small enough so that the driver will
> -	 * hit the free threshold easily and free mbufs timely. Otherwise,
> -	 * guest Tx vring would be starved.
> -	 */
> -	if (dequeue_zero_copy)
> -		tx_ring_size = 64;
> -
>  	tx_rings = (uint16_t)rte_lcore_count();
> 
>  	/* Get port configuration. */
> @@ -457,8 +446,7 @@ us_vhost_usage(const char *prgname)
>  	"		--socket-file: The path of the socket file.\n"
>  	"		--tx-csum [0|1] disable/enable TX checksum offload.\n"
>  	"		--tso [0|1] disable/enable TCP segment offload.\n"
> -	"		--client register a vhost-user socket as client mode.\n"
> -	"		--dequeue-zero-copy enables dequeue zero copy\n",
> +	"		--client register a vhost-user socket as client mode.\n",
>  	       prgname);
>  }
> 
> @@ -483,7 +471,6 @@ us_vhost_parse_args(int argc, char **argv)
>  		{"tx-csum", required_argument, NULL, 0},
>  		{"tso", required_argument, NULL, 0},
>  		{"client", no_argument, &client_mode, 1},
> -		{"dequeue-zero-copy", no_argument, &dequeue_zero_copy, 1},
>  		{"builtin-net-driver", no_argument, &builtin_net_driver, 1},
>  		{NULL, 0, 0, 0},
>  	};
> @@ -1510,9 +1497,6 @@ main(int argc, char *argv[])
>  	if (client_mode)
>  		flags |= RTE_VHOST_USER_CLIENT;
> 
> -	if (dequeue_zero_copy)
> -		flags |= RTE_VHOST_USER_DEQUEUE_ZERO_COPY;
> -
>  	/* Register vhost user driver to handle vhost messages. */
>  	for (i = 0; i < nb_sockets; i++) {
>  		char *file = socket_files + i * PATH_MAX;
> --
> 2.26.2

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

  reply	other threads:[~2020-09-23  5:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 13:35 [dpdk-dev] [PATCH 0/4] pick Maxime Coquelin
2020-09-15 13:35 ` [dpdk-dev] [PATCH 1/4] net/vhost: remove dequeue zero-copy support Maxime Coquelin
2020-09-23  5:41   ` Xia, Chenbo
2020-09-15 13:35 ` [dpdk-dev] [PATCH 2/4] examples/vhost_crypto: use vhost async-copy flag Maxime Coquelin
2020-09-23  5:43   ` Xia, Chenbo
2020-09-15 13:35 ` [dpdk-dev] [PATCH 3/4] examples/vhost: remove dequeue zero-copy support Maxime Coquelin
2020-09-23  5:43   ` Xia, Chenbo [this message]
2020-09-15 13:35 ` [dpdk-dev] [PATCH 4/4] vhost: " Maxime Coquelin
2020-09-23  5:44   ` Xia, Chenbo
2020-09-15 13:41 ` [dpdk-dev] [PATCH 0/4] vhost: remove dequeue zero-copy support (was: pick) Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4063799CF9B4EE8CC8D34B399C380@MN2PR11MB4063.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ian.stokes@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git