From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Suanming Mou <suanmingm@nvidia.com>, Matan Azrad <matan@nvidia.com>
Cc: Raslan Darawsheh <rasland@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid entry assert
Date: Fri, 6 Nov 2020 17:41:27 +0000 [thread overview]
Message-ID: <MWHPR12MB1501A5BE79A6A77CFB84509CDFED0@MWHPR12MB1501.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1604631741-128270-1-git-send-email-suanmingm@nvidia.com>
> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Friday, November 6, 2020 5:02
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix invalid entry assert
>
> The entry variable assert in the mlx5_hlist_register() function is not correct.
> Remove the invalid entry variable.
>
> Fixes: e69a59227db0 ("net/mlx5: support concurrent access for hash list")
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c index
> 13590dd..9889437 100644
> --- a/drivers/net/mlx5/mlx5_utils.c
> +++ b/drivers/net/mlx5/mlx5_utils.c
> @@ -132,7 +132,7 @@ struct mlx5_hlist_entry*
> struct mlx5_hlist_entry *entry;
> uint32_t prev_gen_cnt = 0;
>
> - MLX5_ASSERT(h && entry);
> + MLX5_ASSERT(h);
> /* Use write lock directly for write-most list. */
> if (!h->write_most) {
> prev_gen_cnt = __atomic_load_n(&h->gen_cnt,
> __ATOMIC_ACQUIRE);
> --
> 1.8.3.1
next prev parent reply other threads:[~2020-11-06 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 3:02 Suanming Mou
2020-11-06 17:41 ` Slava Ovsiienko [this message]
2020-11-09 8:21 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR12MB1501A5BE79A6A77CFB84509CDFED0@MWHPR12MB1501.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).