DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC
@ 2020-10-29 17:58 Alexander Kozyrev
  2020-11-01 16:39 ` Slava Ovsiienko
  2020-11-02 14:57 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kozyrev @ 2020-10-29 17:58 UTC (permalink / raw)
  To: dev; +Cc: rasland, viacheslavo, matan

The recent Rx code refactoring moved the incrementing
of the CQ completion index out of the rxq_cq_decompress_v()
function to the rxq_burst_v() function.

The advancing of CQ completion index was removed in SSE
version only causing Neon and Altivec Rx bursts to stall.

Remove the incrementation of CQ completion index for all
the architectures in order to fix the stall.

Fixes: bf7d5157ed ("net/mlx5: refactor vectorized Rx")

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
 drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 1 -
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h b/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
index cf3a795843..4af4ccafca 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
@@ -301,7 +301,6 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,
 	rxq->stats.ibytes += rcvd_byte;
 #endif
 
-	rxq->cq_ci += mcqe_n;
 	return mcqe_n;
 }
 
diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
index 47b6692942..f194cc99b7 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
@@ -240,7 +240,6 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,
 	rxq->stats.ipackets += mcqe_n;
 	rxq->stats.ibytes += rcvd_byte;
 #endif
-	rxq->cq_ci += mcqe_n;
 	return mcqe_n;
 }
 
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC
  2020-10-29 17:58 [dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC Alexander Kozyrev
@ 2020-11-01 16:39 ` Slava Ovsiienko
  2020-11-02 14:57 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2020-11-01 16:39 UTC (permalink / raw)
  To: Alexander Kozyrev, dev; +Cc: Raslan Darawsheh, Matan Azrad

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Thursday, October 29, 2020 19:58
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Subject: [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC
> 
> The recent Rx code refactoring moved the incrementing of the CQ completion
> index out of the rxq_cq_decompress_v() function to the rxq_burst_v()
> function.
> 
> The advancing of CQ completion index was removed in SSE version only
> causing Neon and Altivec Rx bursts to stall.
> 
> Remove the incrementation of CQ completion index for all the architectures in
> order to fix the stall.
> 
> Fixes: bf7d5157ed ("net/mlx5: refactor vectorized Rx")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC
  2020-10-29 17:58 [dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC Alexander Kozyrev
  2020-11-01 16:39 ` Slava Ovsiienko
@ 2020-11-02 14:57 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-11-02 14:57 UTC (permalink / raw)
  To: Alexander Kozyrev, dev; +Cc: Slava Ovsiienko, Matan Azrad

Hi,

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Thursday, October 29, 2020 7:58 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Subject: [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC
Fixed styling issue ARM->Arm 
> 
> The recent Rx code refactoring moved the incrementing
> of the CQ completion index out of the rxq_cq_decompress_v()
> function to the rxq_burst_v() function.
> 
> The advancing of CQ completion index was removed in SSE
> version only causing Neon and Altivec Rx bursts to stall.
> 
> Remove the incrementation of CQ completion index for all
> the architectures in order to fix the stall.
> 
> Fixes: bf7d5157ed ("net/mlx5: refactor vectorized Rx")
Fixed commit id
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-02 14:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 17:58 [dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC Alexander Kozyrev
2020-11-01 16:39 ` Slava Ovsiienko
2020-11-02 14:57 ` Raslan Darawsheh

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git