From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Tom Rix <trix@redhat.com>,
"Chautru, Nicolas" <nicolas.chautru@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code
Date: Mon, 26 Oct 2020 12:03:46 +0000 [thread overview]
Message-ID: <SN6PR11MB3086559CC8618E2E175E8A72FC190@SN6PR11MB3086.namprd11.prod.outlook.com> (raw)
In-Reply-To: <aea55c27-03dc-d7cd-6424-3a118a8c3cc9@redhat.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Tom Rix
> Sent: Wednesday, October 21, 2020 2:58 PM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead
> code
>
>
> On 10/19/20 2:09 PM, Nicolas Chautru wrote:
> > Coverity reported dead code for a few error checks which are indeed
> > not reachable.
> >
> > Coverity issue: 363451, 363454, 363455
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
>
> This change looks fine.
>
> Should remove the 'Coverity issue: ... ' from the log.
>
> Reviewed-by: Tom Rix <trix@redhat.com>
It should stay. That is the convention we use:
git log | grep "Coverity issue"
next prev parent reply other threads:[~2020-10-26 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 21:09 Nicolas Chautru
2020-10-19 21:09 ` Nicolas Chautru
2020-10-21 13:58 ` Tom Rix
2020-10-26 12:03 ` Mcnamara, John [this message]
2020-10-28 11:32 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3086559CC8618E2E175E8A72FC190@SN6PR11MB3086.namprd11.prod.outlook.com \
--to=john.mcnamara@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nicolas.chautru@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).