DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code
@ 2020-10-19 21:09 Nicolas Chautru
  2020-10-19 21:09 ` Nicolas Chautru
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Chautru @ 2020-10-19 21:09 UTC (permalink / raw)
  To: dev, akhil.goyal; +Cc: bruce.richardson, trix, Nicolas Chautru

Removing a few lines of dead code reported recently by coverity.
The related code was not released yet hence does not
required to be fixed on stable branch. 

Coverity issues: 363451, 363454, 363455

Nicolas Chautru (1):
  baseband/acc100: remove logically dead code

 drivers/baseband/acc100/rte_acc100_pmd.c | 9 ---------
 1 file changed, 9 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code
  2020-10-19 21:09 [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code Nicolas Chautru
@ 2020-10-19 21:09 ` Nicolas Chautru
  2020-10-21 13:58   ` Tom Rix
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Chautru @ 2020-10-19 21:09 UTC (permalink / raw)
  To: dev, akhil.goyal; +Cc: bruce.richardson, trix, Nicolas Chautru

Coverity reported dead code for a few error
checks which are indeed not reachable.

Coverity issue: 363451, 363454, 363455

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 drivers/baseband/acc100/rte_acc100_pmd.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
index 47ddbae..5e663a6 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -2519,9 +2519,6 @@
 		r++;
 	}
 
-	if (unlikely(desc == NULL))
-		return current_enqueued_cbs;
-
 #ifdef RTE_LIBRTE_BBDEV_DEBUG
 	if (check_mbuf_total_left(mbuf_total_left) != 0)
 		return -EINVAL;
@@ -3076,9 +3073,6 @@
 		r++;
 	}
 
-	if (unlikely(desc == NULL))
-		return current_enqueued_cbs;
-
 #ifdef RTE_LIBRTE_BBDEV_DEBUG
 	if (check_mbuf_total_left(mbuf_total_left) != 0)
 		return -EINVAL;
@@ -3181,9 +3175,6 @@
 		r++;
 	}
 
-	if (unlikely(desc == NULL))
-		return current_enqueued_cbs;
-
 #ifdef RTE_LIBRTE_BBDEV_DEBUG
 	if (check_mbuf_total_left(mbuf_total_left) != 0)
 		return -EINVAL;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code
  2020-10-19 21:09 ` Nicolas Chautru
@ 2020-10-21 13:58   ` Tom Rix
  2020-10-26 12:03     ` Mcnamara, John
  2020-10-28 11:32     ` Akhil Goyal
  0 siblings, 2 replies; 5+ messages in thread
From: Tom Rix @ 2020-10-21 13:58 UTC (permalink / raw)
  To: Nicolas Chautru, dev, akhil.goyal; +Cc: bruce.richardson


On 10/19/20 2:09 PM, Nicolas Chautru wrote:
> Coverity reported dead code for a few error
> checks which are indeed not reachable.
>
> Coverity issue: 363451, 363454, 363455
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>

This change looks fine.

Should remove the 'Coverity issue: ... ' from the log.

Reviewed-by: Tom Rix <trix@redhat.com>

> ---
>  drivers/baseband/acc100/rte_acc100_pmd.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index 47ddbae..5e663a6 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -2519,9 +2519,6 @@
>  		r++;
>  	}
>  
> -	if (unlikely(desc == NULL))
> -		return current_enqueued_cbs;
> -
>  #ifdef RTE_LIBRTE_BBDEV_DEBUG
>  	if (check_mbuf_total_left(mbuf_total_left) != 0)
>  		return -EINVAL;
> @@ -3076,9 +3073,6 @@
>  		r++;
>  	}
>  
> -	if (unlikely(desc == NULL))
> -		return current_enqueued_cbs;
> -
>  #ifdef RTE_LIBRTE_BBDEV_DEBUG
>  	if (check_mbuf_total_left(mbuf_total_left) != 0)
>  		return -EINVAL;
> @@ -3181,9 +3175,6 @@
>  		r++;
>  	}
>  
> -	if (unlikely(desc == NULL))
> -		return current_enqueued_cbs;
> -
>  #ifdef RTE_LIBRTE_BBDEV_DEBUG
>  	if (check_mbuf_total_left(mbuf_total_left) != 0)
>  		return -EINVAL;


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code
  2020-10-21 13:58   ` Tom Rix
@ 2020-10-26 12:03     ` Mcnamara, John
  2020-10-28 11:32     ` Akhil Goyal
  1 sibling, 0 replies; 5+ messages in thread
From: Mcnamara, John @ 2020-10-26 12:03 UTC (permalink / raw)
  To: Tom Rix, Chautru, Nicolas, dev, akhil.goyal; +Cc: Richardson, Bruce



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Tom Rix
> Sent: Wednesday, October 21, 2020 2:58 PM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead
> code
> 
> 
> On 10/19/20 2:09 PM, Nicolas Chautru wrote:
> > Coverity reported dead code for a few error checks which are indeed
> > not reachable.
> >
> > Coverity issue: 363451, 363454, 363455
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> 
> This change looks fine.
> 
> Should remove the 'Coverity issue: ... ' from the log.
> 
> Reviewed-by: Tom Rix <trix@redhat.com>

It should stay. That is the convention we use:

    git log | grep "Coverity issue"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code
  2020-10-21 13:58   ` Tom Rix
  2020-10-26 12:03     ` Mcnamara, John
@ 2020-10-28 11:32     ` Akhil Goyal
  1 sibling, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2020-10-28 11:32 UTC (permalink / raw)
  To: Tom Rix, Nicolas Chautru, dev; +Cc: bruce.richardson

> 
> On 10/19/20 2:09 PM, Nicolas Chautru wrote:
> > Coverity reported dead code for a few error
> > checks which are indeed not reachable.
> >
> > Coverity issue: 363451, 363454, 363455
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> 
> This change looks fine.
> 
> Should remove the 'Coverity issue: ... ' from the log.
> 
> Reviewed-by: Tom Rix <trix@redhat.com>
> 
Applied to dpdk-next-crypto

Thanks.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-28 11:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 21:09 [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code Nicolas Chautru
2020-10-19 21:09 ` Nicolas Chautru
2020-10-21 13:58   ` Tom Rix
2020-10-26 12:03     ` Mcnamara, John
2020-10-28 11:32     ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git