RE: [PATCH v2] graph: fix graph model check in core binding

["Yan, Zhirun" <zhirun.yan@intel.com>]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Tuesday, July 4, 2023 5:10 PM
> To: Yan, Zhirun <zhirun.yan@intel.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; kirankumark@marvell.com;
> ndabilpuram@marvell.com; Fu, Qi <qi.fu@intel.com>
> Subject: Re: [PATCH v2] graph: fix graph model check in core binding
> 
> On Mon, Jul 3, 2023 at 3:35 PM Zhirun Yan <zhirun.yan@intel.com> wrote:
> >
> > Fix graph model check in core binding with graph. And
> > rte_graph_clone() need to use valid params rather than NULL pointer.
> > Update release notes for new mcore dispatch model.
> 
> 
> Please add Fixes:
Ok.
> 
> > Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> > ---
> >  app/test/test_graph.c                  | 15 ++++++++++++---
> >  doc/guides/rel_notes/release_23_07.rst | 12 ++++++++++++
> >  lib/graph/graph.c                      |  2 +-
> >  3 files changed, 25 insertions(+), 4 deletions(-)
> 
> > +* **Added mcore dispatch model in rte_graph library.**
> > +
> > +  * Added set, get and validate model APIs to enhance graph framework
> > +    to chose different walk models.
> 
> Adding one line for what is "mcore dispatch model" will be good.
> 
Got it. Will add in next version.

> > +  * Added clone graph, bind graph with lcore and affinity node with
> > +    lcore APIs to support mcore dispatch model.
> 
> I think, Above, statement,  you can remove.
Yes. Thanks.

> 
> > +
> >  * **Added PDCP Library.**
> >
> >    Added an experimental library to provide PDCP UL and DL processing of
> packets.
> > @@ -200,6 +207,11 @@ New Features
> >
> >    Enhanced the GRO library to support TCP packets over IPv6 network.
> >
> > +* **Update l3fwd-graph sample application.**
> > +
> > +  Added a new cmdline option ``--model`` which can be used to chose
> > + RTC or mcore dispatch model.
> > +