From: "Yan, Zhirun" <zhirun.yan@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"kirankumark@marvell.com" <kirankumark@marvell.com>,
"ndabilpuram@marvell.com" <ndabilpuram@marvell.com>,
"Fu, Qi" <qi.fu@intel.com>
Subject: RE: [PATCH v3] graph: fix graph model check in core binding
Date: Mon, 10 Jul 2023 05:08:10 +0000 [thread overview]
Message-ID: <SN7PR11MB6775D12E1087E809A0FE25758530A@SN7PR11MB6775.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1M4ChoCDMrn=+DyGvmZgEH03P=DeSDb9uhA=cCXQJ6D3w@mail.gmail.com>
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Friday, July 7, 2023 6:17 PM
> To: Yan, Zhirun <zhirun.yan@intel.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; kirankumark@marvell.com;
> ndabilpuram@marvell.com; Fu, Qi <qi.fu@intel.com>
> Subject: Re: [PATCH v3] graph: fix graph model check in core binding
>
> On Wed, Jul 5, 2023 at 7:38 AM Zhirun Yan <zhirun.yan@intel.com> wrote:
> >
> > Fix graph model check in core binding with graph. And
> > rte_graph_clone()
>
> Two fixes, Lets have two patches. Also tell what is fixed and how it is fixed.
Ok, will do in next version.
>
>
> > need to use valid params rather than NULL pointer. Update release
> > notes for new mcore dispatch model.
> >
> > Fixes: ecb22a294980 ("graph: introduce graph bind unbind API")
> > Fixes: 67e2303cd823 ("test/graph: add functional tests for mcore
> > dispatch model")
> >
> > Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> > ---
> > app/test/test_graph.c | 15 ++++++++++++---
> > doc/guides/rel_notes/release_23_07.rst | 11 +++++++++++
> > lib/graph/graph.c | 2 +-
> > 3 files changed, 24 insertions(+), 4 deletions(-)
> >
> > diff --git a/app/test/test_graph.c b/app/test/test_graph.c index
> > 8609c0b3a4..8983363c8e 100644
> > --- a/app/test/test_graph.c
> > +++ b/app/test/test_graph.c
> > @@ -702,6 +702,7 @@
> test_graph_model_mcore_dispatch_node_lcore_affinity_set(void)
> > unsigned int worker_lcore = RTE_MAX_LCORE;
> > rte_node_t nid = RTE_NODE_ID_INVALID;
> > char node_name[64] = "test_node00";
> > + struct rte_graph_param graph_conf;
>
> Initialize with zero or defaults, aka add = { 0 }
Got it, thanks.
next prev parent reply other threads:[~2023-07-10 5:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 7:29 [PATCH v1] " Zhirun Yan
2023-07-03 9:55 ` [PATCH v2] " Zhirun Yan
2023-07-04 9:10 ` Jerin Jacob
2023-07-05 0:50 ` Yan, Zhirun
2023-07-05 1:56 ` [PATCH v3] " Zhirun Yan
2023-07-07 10:16 ` Jerin Jacob
2023-07-10 5:08 ` Yan, Zhirun [this message]
2023-07-10 7:15 ` [PATCH v4 0/2] fix graph issues Zhirun Yan
2023-07-10 7:15 ` [PATCH v4 1/2] graph: fix graph functional tests with valid params Zhirun Yan
2023-07-10 9:21 ` Jerin Jacob
2023-07-10 7:15 ` [PATCH v4 2/2] graph: fix graph model check in core binding Zhirun Yan
2023-07-10 9:29 ` Jerin Jacob
2023-07-12 14:01 ` [PATCH v4 0/2] fix graph issues Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN7PR11MB6775D12E1087E809A0FE25758530A@SN7PR11MB6775.namprd11.prod.outlook.com \
--to=zhirun.yan@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=qi.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).