From: Phil Yang <Phil.Yang@arm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>, dev <dev@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>,
David Christensen <drc@linux.vnet.ibm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>,
Dodji Seketeli <dodji@redhat.com>,
Aaron Conole <aconole@redhat.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations
Date: Wed, 15 Jul 2020 16:29:08 +0000 [thread overview]
Message-ID: <VE1PR08MB46403E351B011D1812A40127E97E0@VE1PR08MB4640.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xOUOg9GMCtGtk61cfNU1JrftgkCQ+jahk9Eetocmx+aA@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, July 15, 2020 8:29 PM
> To: Phil Yang <Phil.Yang@arm.com>
> Cc: Olivier Matz <olivier.matz@6wind.com>; dev <dev@dpdk.org>; Stephen
> Hemminger <stephen@networkplumber.org>; David Christensen
> <drc@linux.vnet.ibm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; nd <nd@arm.com>; Dodji Seketeli
> <dodji@redhat.com>; Aaron Conole <aconole@redhat.com>
> Subject: Re: [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt
> operations
>
> On Thu, Jul 9, 2020 at 5:59 PM Phil Yang <phil.yang@arm.com> wrote:
> >
> > Use C11 atomic built-ins with explicit ordering instead of rte_atomic
> > ops which enforce unnecessary barriers on aarch64.
> >
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > ---
> > v4:
> > 1. Add union for refcnt_atomic and refcnt in rte_mbuf_ext_shared_info
> > to avoid ABI breakage. (Olivier)
> > 2. Add notice of refcnt_atomic deprecation. (Honnappa)
>
> v4 does not pass the checks (in both my env, and Travis).
> https://travis-ci.com/github/ovsrobot/dpdk/jobs/359393389#L2405
I had tested with test-meson-builds in my env and it didn't give any error message. The reference version is v20.05.
$ DPDK_ABI_REF_DIR=$PWD/reference DPDK_ABI_REF_VERSION=v20.05 ./devtools/test-meson-builds.sh
It seems to be a problem with my test environment.
I will fix this problem as soon as possible.
>
> It seems the robot had a hiccup as I can't see a report in the test-report ml.
>
>
> --
> David Marchand
next prev parent reply other threads:[~2020-07-15 16:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:26 [dpdk-dev] [PATCH] mbuf: use c11 atomics " Phil Yang
2020-07-03 15:38 ` David Marchand
2020-07-06 8:03 ` Phil Yang
2020-07-07 10:10 ` [dpdk-dev] [PATCH v2] mbuf: use C11 " Phil Yang
2020-07-07 17:13 ` Stephen Hemminger
2020-07-08 4:48 ` Phil Yang
2020-07-08 11:43 ` Olivier Matz
2020-07-09 9:52 ` Phil Yang
2020-07-08 5:11 ` Phil Yang
2020-07-08 11:44 ` Olivier Matz
2020-07-09 10:00 ` Phil Yang
2020-07-09 10:10 ` [dpdk-dev] [PATCH v3] mbuf: use C11 atomic built-ins " Phil Yang
2020-07-09 11:03 ` Olivier Matz
2020-07-09 13:00 ` Phil Yang
2020-07-09 13:31 ` Honnappa Nagarahalli
2020-07-09 14:10 ` Phil Yang
2020-07-09 15:58 ` [dpdk-dev] [PATCH v4 1/2] " Phil Yang
2020-07-09 15:58 ` [dpdk-dev] [PATCH v4 2/2] doc: announce deprecation of refcnt atomic member Phil Yang
2020-07-10 2:55 ` Ruifeng Wang
2020-07-13 15:54 ` Phil Yang
2020-07-14 10:41 ` Ananyev, Konstantin
2020-07-15 12:29 ` [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations David Marchand
2020-07-15 12:49 ` Aaron Conole
2020-07-15 16:29 ` Phil Yang [this message]
2020-07-16 4:16 ` Phil Yang
2020-07-16 11:30 ` David Marchand
2020-07-16 13:20 ` Dodji Seketeli
2020-07-16 19:11 ` David Marchand
2020-07-17 4:41 ` Phil Yang
2020-07-16 11:32 ` Olivier Matz
2020-07-17 4:36 ` [dpdk-dev] [PATCH v5 1/2] mbuf: use C11 atomic builtins " Phil Yang
2020-07-17 4:36 ` [dpdk-dev] [PATCH v5 2/2] doc: announce deprecation of refcnt atomic member Phil Yang
2020-07-17 11:45 ` Olivier Matz
2020-07-17 14:32 ` David Marchand
2020-07-17 14:35 ` David Marchand
2020-07-17 16:06 ` Ananyev, Konstantin
2020-07-17 16:20 ` Bruce Richardson
2020-07-21 8:35 ` David Marchand
2020-07-21 8:48 ` Ananyev, Konstantin
2020-07-21 8:37 ` [dpdk-dev] [PATCH v5 1/2] mbuf: use C11 atomic builtins for refcnt operations David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB46403E351B011D1812A40127E97E0@VE1PR08MB4640.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=drc@linux.vnet.ibm.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).