From: Phil Yang <Phil.Yang@arm.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Olivier Matz <olivier.matz@6wind.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>, nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH v3] mbuf: use C11 atomic built-ins for refcnt operations Date: Thu, 9 Jul 2020 14:10:49 +0000 Message-ID: <VE1PR08MB4640B53CD9A10D3843328EA1E9640@VE1PR08MB4640.eurprd08.prod.outlook.com> (raw) In-Reply-To: <DB6PR0802MB22163DF5D90C9FCC06C43B0198640@DB6PR0802MB2216.eurprd08.prod.outlook.com> <snip> > > > > > > > Hi Phil, > > > > > > On Thu, Jul 09, 2020 at 06:10:42PM +0800, Phil Yang wrote: > > > > Use C11 atomic built-ins with explicit ordering instead of > > > > rte_atomic ops which enforce unnecessary barriers on aarch64. > > > > > > > > Signed-off-by: Phil Yang <phil.yang@arm.com> > > > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > > > > --- > > > > v3: > > > > 1.Fix ABI breakage. > > > > 2.Simplify data type cast. > > > > > > > > v2: > > > > Fix ABI issue: revert the rte_mbuf_ext_shared_info struct refcnt > > > > field to refcnt_atomic. > > > > > > > > lib/librte_mbuf/rte_mbuf.c | 1 - > > > > lib/librte_mbuf/rte_mbuf.h | 19 ++++++++++--------- > > > > lib/librte_mbuf/rte_mbuf_core.h | 2 +- > > > > 3 files changed, 11 insertions(+), 11 deletions(-) > > > > > > <snip> > > > > > > > > /* Reinitialize counter before mbuf freeing. */ diff --git > > > > a/lib/librte_mbuf/rte_mbuf_core.h > > > b/lib/librte_mbuf/rte_mbuf_core.h > > > > index 16600f1..d65d1c8 100644 > > > > --- a/lib/librte_mbuf/rte_mbuf_core.h > > > > +++ b/lib/librte_mbuf/rte_mbuf_core.h > > > > @@ -679,7 +679,7 @@ typedef void > > > (*rte_mbuf_extbuf_free_callback_t)(void *addr, void *opaque); > > > > struct rte_mbuf_ext_shared_info { > > > > rte_mbuf_extbuf_free_callback_t free_cb; /**< Free callback > > > function */ > > > > void *fcb_opaque; /**< Free callback argument */ > > > > -rte_atomic16_t refcnt_atomic; /**< Atomically accessed refcnt */ > > > > +uint16_t refcnt_atomic; /**< Atomically accessed refcnt */ > > > > }; > > > > > > To avoid an API breakage (i.e. currently, an application that accesses > > > to refcnt_atomic expects that its type is rte_atomic16_t), I suggest > > > to do the same than in the mbuf struct: > > > > > > union { > > > rte_atomic16_t refcnt_atomic; > > > uint16_t refcnt; > > > }; > > > > > > I hope the ABI checker won't complain. > > > > > > It will also be better for 20.11 when the deprecated fields will be > > > renamed: the remaining one will be called 'refcnt' in both mbuf and > > > mbuf_ext_shared_info. > Does this need a deprecation notice in 20.08? Yes. We'd better do that. I will add a notice for it in this patch. Thanks. > > > > > Got it. I agree with you. > > It should work. In my local test machine, the ABI checker happy with this > > approach. > > Once the test is done, I will upstream the new patch. > > > > Appreciate your comments. > > > > Thanks, > > Phil
next prev parent reply other threads:[~2020-07-09 14:11 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-11 10:26 [dpdk-dev] [PATCH] mbuf: use c11 atomics " Phil Yang 2020-07-03 15:38 ` David Marchand 2020-07-06 8:03 ` Phil Yang 2020-07-07 10:10 ` [dpdk-dev] [PATCH v2] mbuf: use C11 " Phil Yang 2020-07-07 17:13 ` Stephen Hemminger 2020-07-08 4:48 ` Phil Yang 2020-07-08 11:43 ` Olivier Matz 2020-07-09 9:52 ` Phil Yang 2020-07-08 5:11 ` Phil Yang 2020-07-08 11:44 ` Olivier Matz 2020-07-09 10:00 ` Phil Yang 2020-07-09 10:10 ` [dpdk-dev] [PATCH v3] mbuf: use C11 atomic built-ins " Phil Yang 2020-07-09 11:03 ` Olivier Matz 2020-07-09 13:00 ` Phil Yang 2020-07-09 13:31 ` Honnappa Nagarahalli 2020-07-09 14:10 ` Phil Yang [this message] 2020-07-09 15:58 ` [dpdk-dev] [PATCH v4 1/2] " Phil Yang 2020-07-09 15:58 ` [dpdk-dev] [PATCH v4 2/2] doc: announce deprecation of refcnt atomic member Phil Yang 2020-07-10 2:55 ` Ruifeng Wang 2020-07-13 15:54 ` Phil Yang 2020-07-14 10:41 ` Ananyev, Konstantin 2020-07-15 12:29 ` [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations David Marchand 2020-07-15 12:49 ` Aaron Conole 2020-07-15 16:29 ` Phil Yang 2020-07-16 4:16 ` Phil Yang 2020-07-16 11:30 ` David Marchand 2020-07-16 13:20 ` Dodji Seketeli 2020-07-16 19:11 ` David Marchand 2020-07-17 4:41 ` Phil Yang 2020-07-16 11:32 ` Olivier Matz 2020-07-17 4:36 ` [dpdk-dev] [PATCH v5 1/2] mbuf: use C11 atomic builtins " Phil Yang 2020-07-17 4:36 ` [dpdk-dev] [PATCH v5 2/2] doc: announce deprecation of refcnt atomic member Phil Yang 2020-07-17 11:45 ` Olivier Matz 2020-07-17 14:32 ` David Marchand 2020-07-17 14:35 ` David Marchand 2020-07-17 16:06 ` Ananyev, Konstantin 2020-07-17 16:20 ` Bruce Richardson 2020-07-21 8:35 ` David Marchand 2020-07-21 8:48 ` Ananyev, Konstantin 2020-07-21 8:37 ` [dpdk-dev] [PATCH v5 1/2] mbuf: use C11 atomic builtins for refcnt operations David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VE1PR08MB4640B53CD9A10D3843328EA1E9640@VE1PR08MB4640.eurprd08.prod.outlook.com \ --to=phil.yang@arm.com \ --cc=Honnappa.Nagarahalli@arm.com \ --cc=Ruifeng.Wang@arm.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=drc@linux.vnet.ibm.com \ --cc=nd@arm.com \ --cc=olivier.matz@6wind.com \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git