From: David Marchand <david.marchand@redhat.com> To: Phil Yang <Phil.Yang@arm.com>, Olivier Matz <olivier.matz@6wind.com>, Dodji Seketeli <dodji@redhat.com>, Ray Kinsella <mdr@ashroe.eu> Cc: dev <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>, David Christensen <drc@linux.vnet.ibm.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>, Aaron Conole <aconole@redhat.com> Subject: Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations Date: Thu, 16 Jul 2020 13:30:09 +0200 Message-ID: <CAJFAV8x42GYGf-OL=WBKzeP5Sfiu0X=zRGa3cWct1fWSCTiUgw@mail.gmail.com> (raw) In-Reply-To: <VE1PR08MB464036DF852519C655A31222E97F0@VE1PR08MB4640.eurprd08.prod.outlook.com> On Thu, Jul 16, 2020 at 6:16 AM Phil Yang <Phil.Yang@arm.com> wrote: > > David Marchand <david.marchand@redhat.com> writes: > > > Subject: Re: [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt > > operations > > > > On Thu, Jul 9, 2020 at 5:59 PM Phil Yang <phil.yang@arm.com> wrote: > > > > > > Use C11 atomic built-ins with explicit ordering instead of rte_atomic > > > ops which enforce unnecessary barriers on aarch64. > > > > > > Signed-off-by: Phil Yang <phil.yang@arm.com> > > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > > > --- > > > v4: > > > 1. Add union for refcnt_atomic and refcnt in rte_mbuf_ext_shared_info > > > to avoid ABI breakage. (Olivier) > > > 2. Add notice of refcnt_atomic deprecation. (Honnappa) > > > > v4 does not pass the checks (in both my env, and Travis). > > https://travis-ci.com/github/ovsrobot/dpdk/jobs/359393389#L2405 > > I think we need an exception in 'libabigail.abignore' for this change. > Is that OK with you? Testing the series with libabigail 1.7.0: Functions changes summary: 0 Removed, 1 Changed (6 filtered out), 0 Added functions Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 1 function with some indirect sub-type change: [C]'function unsigned int rte_reorder_drain(rte_reorder_buffer*, rte_mbuf**, unsigned int)' at rte_reorder.c:367:1 has some indirect sub-type changes: parameter 2 of type 'rte_mbuf**' has sub-type changes: in pointed to type 'rte_mbuf*': in pointed to type 'struct rte_mbuf' at rte_mbuf_core.h:469:1: type size hasn't changed 1 data member changes (1 filtered): type of 'rte_mbuf_ext_shared_info* rte_mbuf::shinfo' changed: in pointed to type 'struct rte_mbuf_ext_shared_info' at rte_mbuf_core.h:679:1: type size hasn't changed 1 data member change: data member rte_atomic16_t rte_mbuf_ext_shared_info::refcnt_atomic at offset 128 (in bits) became anonymous data member 'union {rte_atomic16_t refcnt_atomic; uint16_t refcnt;}' Error: ABI issue reported for 'abidiff --suppr /home/dmarchan/dpdk/devtools/../devtools/libabigail.abignore --no-added-syms --headers-dir1 /home/dmarchan/abi/v20.05/build-gcc-static/usr/local/include --headers-dir2 /home/dmarchan/builds/build-gcc-static/install/usr/local/include /home/dmarchan/abi/v20.05/build-gcc-static/dump/librte_reorder.dump /home/dmarchan/builds/build-gcc-static/install/dump/librte_reorder.dump' ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue). We will have no other update on mbuf for 20.08, so the following rule can do the job for 20.08 and we will remove it in 20.11. diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index daa4631bf..b35f91257 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -52,6 +52,10 @@ [suppress_type] type_kind = struct name = rte_epoll_event +; Ignore updates of rte_mbuf_ext_shared_info +[suppress_type] + type_kind = struct + name = rte_mbuf_ext_shared_info ;;;;;;;;;;;;;;;;;;;;;; ; Temporary exceptions till DPDK 20.11 Olivier, Dodji, Ray? -- David Marchand
next prev parent reply other threads:[~2020-07-16 11:30 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-11 10:26 [dpdk-dev] [PATCH] mbuf: use c11 atomics " Phil Yang 2020-07-03 15:38 ` David Marchand 2020-07-06 8:03 ` Phil Yang 2020-07-07 10:10 ` [dpdk-dev] [PATCH v2] mbuf: use C11 " Phil Yang 2020-07-07 17:13 ` Stephen Hemminger 2020-07-08 4:48 ` Phil Yang 2020-07-08 11:43 ` Olivier Matz 2020-07-09 9:52 ` Phil Yang 2020-07-08 5:11 ` Phil Yang 2020-07-08 11:44 ` Olivier Matz 2020-07-09 10:00 ` Phil Yang 2020-07-09 10:10 ` [dpdk-dev] [PATCH v3] mbuf: use C11 atomic built-ins " Phil Yang 2020-07-09 11:03 ` Olivier Matz 2020-07-09 13:00 ` Phil Yang 2020-07-09 13:31 ` Honnappa Nagarahalli 2020-07-09 14:10 ` Phil Yang 2020-07-09 15:58 ` [dpdk-dev] [PATCH v4 1/2] " Phil Yang 2020-07-09 15:58 ` [dpdk-dev] [PATCH v4 2/2] doc: announce deprecation of refcnt atomic member Phil Yang 2020-07-10 2:55 ` Ruifeng Wang 2020-07-13 15:54 ` Phil Yang 2020-07-14 10:41 ` Ananyev, Konstantin 2020-07-15 12:29 ` [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations David Marchand 2020-07-15 12:49 ` Aaron Conole 2020-07-15 16:29 ` Phil Yang 2020-07-16 4:16 ` Phil Yang 2020-07-16 11:30 ` David Marchand [this message] 2020-07-16 13:20 ` Dodji Seketeli 2020-07-16 19:11 ` David Marchand 2020-07-17 4:41 ` Phil Yang 2020-07-16 11:32 ` Olivier Matz 2020-07-17 4:36 ` [dpdk-dev] [PATCH v5 1/2] mbuf: use C11 atomic builtins " Phil Yang 2020-07-17 4:36 ` [dpdk-dev] [PATCH v5 2/2] doc: announce deprecation of refcnt atomic member Phil Yang 2020-07-17 11:45 ` Olivier Matz 2020-07-17 14:32 ` David Marchand 2020-07-17 14:35 ` David Marchand 2020-07-17 16:06 ` Ananyev, Konstantin 2020-07-17 16:20 ` Bruce Richardson 2020-07-21 8:35 ` David Marchand 2020-07-21 8:48 ` Ananyev, Konstantin 2020-07-21 8:37 ` [dpdk-dev] [PATCH v5 1/2] mbuf: use C11 atomic builtins for refcnt operations David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJFAV8x42GYGf-OL=WBKzeP5Sfiu0X=zRGa3cWct1fWSCTiUgw@mail.gmail.com' \ --to=david.marchand@redhat.com \ --cc=Honnappa.Nagarahalli@arm.com \ --cc=Phil.Yang@arm.com \ --cc=Ruifeng.Wang@arm.com \ --cc=aconole@redhat.com \ --cc=dev@dpdk.org \ --cc=dodji@redhat.com \ --cc=drc@linux.vnet.ibm.com \ --cc=mdr@ashroe.eu \ --cc=nd@arm.com \ --cc=olivier.matz@6wind.com \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git