DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable
@ 2019-06-28  3:44 Honnappa Nagarahalli
  2019-06-28  3:44 ` [dpdk-dev] [PATCH 2/2] test/rcu: address test case failure Honnappa Nagarahalli
                   ` (3 more replies)
  0 siblings, 4 replies; 17+ messages in thread
From: Honnappa Nagarahalli @ 2019-06-28  3:44 UTC (permalink / raw)
  To: honnappa.nagarahalli; +Cc: dev, david.marchand, ruifeng.wang, nd, stable

num_cores is of type uint8_t. This results in the following
compilation error.

test_rcu_qsbr_perf.c:649:16: error: comparison is always false
due to limited range of data type [-Werror=type-limits]
  if (num_cores >= RTE_MAX_LCORE) {
                ^~

RTE_MAX_LCORE is set to 256 for armv8 config.

Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count")
Cc: stable@dpdk.org

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 app/test/test_rcu_qsbr.c      | 4 ++--
 app/test/test_rcu_qsbr_perf.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
index 943a1e370..0c6267ee9 100644
--- a/app/test/test_rcu_qsbr.c
+++ b/app/test/test_rcu_qsbr.c
@@ -27,7 +27,7 @@
 #define TEST_RCU_QSBR_CNT_INIT 1
 
 uint16_t enabled_core_ids[RTE_MAX_LCORE];
-uint8_t num_cores;
+uint16_t num_cores;
 
 static uint32_t *keys;
 #define TOTAL_ENTRY (1024 * 8)
@@ -891,7 +891,7 @@ static int
 test_rcu_qsbr_mw_mv_mqs(void)
 {
 	int i, j;
-	uint8_t test_cores;
+	uint16_t test_cores;
 
 	writer_done = 0;
 	test_cores = num_cores / 4;
diff --git a/app/test/test_rcu_qsbr_perf.c b/app/test/test_rcu_qsbr_perf.c
index 363365f46..b1a910423 100644
--- a/app/test/test_rcu_qsbr_perf.c
+++ b/app/test/test_rcu_qsbr_perf.c
@@ -17,7 +17,7 @@
 
 /* Check condition and return an error if true. */
 static uint16_t enabled_core_ids[RTE_MAX_LCORE];
-static uint8_t num_cores;
+static uint16_t num_cores;
 
 static uint32_t *keys;
 #define TOTAL_ENTRY (1024 * 8)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2019-06-29 12:26 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-28  3:44 [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable Honnappa Nagarahalli
2019-06-28  3:44 ` [dpdk-dev] [PATCH 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28  9:16   ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-06-28 13:53     ` Honnappa Nagarahalli
2019-06-28 14:09       ` David Marchand
2019-06-28 16:36         ` Honnappa Nagarahalli
2019-06-28 16:54           ` David Marchand
2019-06-28  9:09 ` [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 13:34   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-06-28 16:38     ` Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-dev] [PATCH v2 " Honnappa Nagarahalli
2019-06-28 16:35   ` [dpdk-dev] [PATCH v2 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 17:11   ` [dpdk-dev] [PATCH v2 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 18:43 ` [dpdk-dev] [PATCH v3 " Honnappa Nagarahalli
2019-06-28 18:43   ` [dpdk-dev] [PATCH v3 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 18:54   ` [dpdk-dev] [PATCH v3 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-29 12:25     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).