DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Apeksha Gupta <apeksha.gupta@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
	"declan.doherty@intel.com" <declan.doherty@intel.com>,
	"asomalap@amd.com" <asomalap@amd.com>,
	"anoobj@marvell.com" <anoobj@marvell.com>,
	"roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
	"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
	"rnagadheeraj@marvell.com" <rnagadheeraj@marvell.com>,
	"adwivedi@marvell.com" <adwivedi@marvell.com>,
	"jianjay.zhou@huawei.com" <jianjay.zhou@huawei.com>,
	"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
	"adamx.dybkowski@intel.com" <adamx.dybkowski@intel.com>,
	Apeksha Gupta <apeksha.gupta@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v4] Test/crypto: check valid test_stats before running test
Date: Sun, 17 May 2020 14:09:05 +0000	[thread overview]
Message-ID: <VI1PR04MB3168FB38157A03C2A23C6A0FE6BB0@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200516015514.8773-1-apeksha.gupta@nxp.com>

> Test_stats is an optional cryptodev op and if it is not defined by the
> PMD, it should not run the test cases for it.
> 
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> ---

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Title and description of the patch updated as
    test/crypto: fix statistics case

    The test case - test_stats is directly accessing the
    cryptodev and its dev_ops which are internal to library
    and should not be used directly by the application.
    However, the test case is also missing to check for the
    error ENOTSUP. It should skip the case if the API returns
    ENOTSUP. This patch fixes these two issues.

    Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
    Cc: stable@dpdk.org

    Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>

Applied to dpdk-next-crypto.

Thanks.

      reply	other threads:[~2020-05-17 14:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15  7:32 [dpdk-dev] [PATCH v2] " Apeksha Gupta
2020-05-15  7:42 ` Ruifeng Wang
2020-05-15  7:56 ` [dpdk-dev] [PATCH v3] " Apeksha Gupta
2020-05-15  8:03   ` Ruifeng Wang
2020-05-15 10:00   ` Ananyev, Konstantin
2020-05-15 17:45     ` Akhil Goyal
2020-05-16  1:55   ` [dpdk-dev] [PATCH v4] " Apeksha Gupta
2020-05-17 14:09     ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB3168FB38157A03C2A23C6A0FE6BB0@VI1PR04MB3168.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=adwivedi@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=apeksha.gupta@nxp.com \
    --cc=asomalap@amd.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=jianjay.zhou@huawei.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=rnagadheeraj@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).