From: Bill Zhou <dongz@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
Ori Kam <orika@mellanox.com>, Matan Azrad <matan@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging
Date: Sun, 26 Apr 2020 07:23:02 +0000 [thread overview]
Message-ID: <VI1PR0502MB2943588E7978B4CF37362029DDAE0@VI1PR0502MB2943.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <0c030470-eb56-ee89-0240-df0b4619c854@intel.com>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Saturday, April 25, 2020 12:25 AM
> To: Bill Zhou <dongz@mellanox.com>; wenzhuo.lu@intel.com;
> jingjing.wu@intel.com; bernard.iremonger@intel.com; Ori Kam
> <orika@mellanox.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging
>
> On 4/24/2020 11:55 AM, Bill Zhou wrote:
> > Currently, there is no way to check the aging event or to get the
> > current aged flows in testpmd, this patch include those implements, it's
> included:
> > - Registering aging event based on verbose level, when set verbose > 0,
> > will register this event, otherwise, remove this event. In this event
> > only dump one line of log to user there is one aging event coming.
> > - Add new command to list all aged flows, meanwhile, we can set
> parameter
> > to destroy it.
>
> Can you please document new feature and command?
>
> Instead of overloading the 'verbose', what do you think having explicit
> command to register aging events? ("flow aged register <port_id>"?) I think
> many of the verbose usage won't really interest in the flow aging.
>
Yes, some of the verbose usage indeed not interest in the flow aging. But If we use
register or unregister event to one port, sometime, it will repeat many times for
every ports.
What do you think if we register this event all the time, and introduce new global
var from command to control the event export to application ?
for example: set aged_flow_event_print_en [0 | 1]
> >
> > Signed-off-by: Bill Zhou <dongz@mellanox.com>
>
> <...>
next prev parent reply other threads:[~2020-04-26 7:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 10:55 Bill Zhou
2020-04-24 16:25 ` Ferruh Yigit
2020-04-26 7:23 ` Bill Zhou [this message]
2020-04-27 14:13 ` Ferruh Yigit
2020-04-27 15:12 ` Matan Azrad
2020-04-30 22:26 ` Ferruh Yigit
2020-04-30 15:53 ` [dpdk-dev] [PATCH v2] " Bill Zhou
2020-04-30 22:43 ` Ferruh Yigit
2020-05-01 6:51 ` Matan Azrad
2020-05-01 9:27 ` Ferruh Yigit
2020-05-01 11:28 ` Matan Azrad
2020-05-01 11:54 ` Ferruh Yigit
2020-05-01 12:45 ` Matan Azrad
2020-05-01 13:38 ` Ferruh Yigit
2020-05-01 15:14 ` Matan Azrad
2020-05-01 15:44 ` Ferruh Yigit
2020-05-02 14:00 ` [dpdk-dev] [PATCH v3] " Bill Zhou
2020-05-03 8:59 ` [dpdk-dev] [PATCH v4] " Bill Zhou
2020-05-03 9:46 ` Matan Azrad
2020-05-03 14:58 ` Ori Kam
2020-05-05 8:37 ` Ferruh Yigit
2020-05-05 9:11 ` Matan Azrad
2020-05-05 9:23 ` Ferruh Yigit
2020-05-05 9:49 ` [dpdk-dev] [PATCH v5] " Bill Zhou
2020-05-05 10:09 ` Ori Kam
2020-05-05 15:11 ` Ferruh Yigit
2020-05-06 8:04 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0502MB2943588E7978B4CF37362029DDAE0@VI1PR0502MB2943.eurprd05.prod.outlook.com \
--to=dongz@mellanox.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).