From: Ferruh Yigit <ferruh.yigit@intel.com> To: Matan Azrad <matan@mellanox.com>, Bill Zhou <dongz@mellanox.com>, "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>, "jingjing.wu@intel.com" <jingjing.wu@intel.com>, "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>, Ori Kam <orika@mellanox.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging Date: Thu, 30 Apr 2020 23:26:37 +0100 Message-ID: <ebce456f-26bf-e150-f064-260741a64e4c@intel.com> (raw) In-Reply-To: <AM0PR0502MB401949A64CEB0F1711D0492FD2AF0@AM0PR0502MB4019.eurprd05.prod.outlook.com> On 4/27/2020 4:12 PM, Matan Azrad wrote: > Hi > > From: Ferruh Yigit >> On 4/26/2020 8:23 AM, Bill Zhou wrote: >>> >>> >>>> -----Original Message----- >>>> From: Ferruh Yigit <ferruh.yigit@intel.com> >>>> Sent: Saturday, April 25, 2020 12:25 AM >>>> To: Bill Zhou <dongz@mellanox.com>; wenzhuo.lu@intel.com; >>>> jingjing.wu@intel.com; bernard.iremonger@intel.com; Ori Kam >>>> <orika@mellanox.com> >>>> Cc: dev@dpdk.org >>>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging >>>> >>>> On 4/24/2020 11:55 AM, Bill Zhou wrote: >>>>> Currently, there is no way to check the aging event or to get the >>>>> current aged flows in testpmd, this patch include those implements, >>>>> it's >>>> included: >>>>> - Registering aging event based on verbose level, when set verbose > 0, >>>>> will register this event, otherwise, remove this event. In this event >>>>> only dump one line of log to user there is one aging event coming. >>>>> - Add new command to list all aged flows, meanwhile, we can set >>>> parameter >>>>> to destroy it. >>>> >>>> Can you please document new feature and command? >>>> >>>> Instead of overloading the 'verbose', what do you think having >>>> explicit command to register aging events? ("flow aged register >>>> <port_id>"?) I think many of the verbose usage won't really interest in >> the flow aging. >>>> >>> >>> Yes, some of the verbose usage indeed not interest in the flow aging. >>> But If we use register or unregister event to one port, sometime, it >>> will repeat many times for every ports. >>> What do you think if we register this event all the time, and >>> introduce new global var from command to control the event export to >> application ? >>> for example: set aged_flow_event_print_en [0 | 1] >> >> I am not also sure about registering this event always, you can register for all >> ports with same command, as we do in many commands: >> "flow aged register <port_id>|all" >> >> When argument is "all" it registers for all ports, when it is a specific port_id, >> registers for that port id. >> And it is good to have 'unregister' command too. > > As I can see in testpmd default, it all the time registers to all events.. > See register_eth_event_callback. You are right. > > I suggest to catch the age event in callback and print it only when set aged_flow_event_print_en is on. +1 > > > Matan > > >> >>> >>>>> >>>>> Signed-off-by: Bill Zhou <dongz@mellanox.com> >>>> >>>> <...> >
next prev parent reply other threads:[~2020-04-30 22:26 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-24 10:55 Bill Zhou 2020-04-24 16:25 ` Ferruh Yigit 2020-04-26 7:23 ` Bill Zhou 2020-04-27 14:13 ` Ferruh Yigit 2020-04-27 15:12 ` Matan Azrad 2020-04-30 22:26 ` Ferruh Yigit [this message] 2020-04-30 15:53 ` [dpdk-dev] [PATCH v2] " Bill Zhou 2020-04-30 22:43 ` Ferruh Yigit 2020-05-01 6:51 ` Matan Azrad 2020-05-01 9:27 ` Ferruh Yigit 2020-05-01 11:28 ` Matan Azrad 2020-05-01 11:54 ` Ferruh Yigit 2020-05-01 12:45 ` Matan Azrad 2020-05-01 13:38 ` Ferruh Yigit 2020-05-01 15:14 ` Matan Azrad 2020-05-01 15:44 ` Ferruh Yigit 2020-05-02 14:00 ` [dpdk-dev] [PATCH v3] " Bill Zhou 2020-05-03 8:59 ` [dpdk-dev] [PATCH v4] " Bill Zhou 2020-05-03 9:46 ` Matan Azrad 2020-05-03 14:58 ` Ori Kam 2020-05-05 8:37 ` Ferruh Yigit 2020-05-05 9:11 ` Matan Azrad 2020-05-05 9:23 ` Ferruh Yigit 2020-05-05 9:49 ` [dpdk-dev] [PATCH v5] " Bill Zhou 2020-05-05 10:09 ` Ori Kam 2020-05-05 15:11 ` Ferruh Yigit 2020-05-06 8:04 ` Matan Azrad
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ebce456f-26bf-e150-f064-260741a64e4c@intel.com \ --to=ferruh.yigit@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=dev@dpdk.org \ --cc=dongz@mellanox.com \ --cc=jingjing.wu@intel.com \ --cc=matan@mellanox.com \ --cc=orika@mellanox.com \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git