Re: [dpdk-dev] [PATCH v5 3/3] app/testpmd: add Tx metadata debug commands

[Dekel Peled <dekelp@mellanox.com>]

Thanks, PSB.

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, October 18, 2018 10:57 AM
> To: Dekel Peled <dekelp@mellanox.com>; wenzhuo.lu@intel.com;
> jingjing.wu@intel.com; bernard.iremonger@intel.com;
> olivier.matz@6wind.com; Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> Thomas Monjalon <thomas@monjalon.net>; arybchenko@solarflare.com
> Cc: Shahaf Shuler <shahafs@mellanox.com>; dev@dpdk.org; Ori Kam
> <orika@mellanox.com>
> Subject: Re: [PATCH v5 3/3] app/testpmd: add Tx metadata debug
> commands
> 
> On 10/17/2018 1:03 PM, Dekel Peled wrote:
> > As described in [1],[2] this series adds option to set metadata value
> > as match pattern when creating a new flow rule.
> >
> > This patch introduces code for debug porpuse only.
> > The new 'config' command takes a 32 bit value and stores it per port:
> > 	port config <port_id> tx_metadata <value>
> >
> > testpmd will add to any Tx packet sent from this port the metadata
> > value, and set ol_flags accordingly.
> >
> > A matching 'show' command is added to read the configured value:
> > 	port config <port_id> tx_metadata <value>
> >
> > [1] "ethdev: support metadata as flow rule criteria"
> > [2] "app/testpmd: support metadata as flow rule criteria"
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> 
> <...>
> 
> > @@ -857,6 +857,13 @@ Disable hardware insertion of a VLAN header in
> packets sent on a port::
> >
> >     testpmd> tx_vlan reset (port_id)
> >
> > +tx_metadata set
> > +~~~~~~~~~~~~~~~
> > +
> > +Set metadata value to insert in packets sent to PMD::
> > +
> > +   testpmd> tx_metadata set (port_id) (value)
> > +
> 
> Documentation is wrong, also show part is missing, can you please update it?

My mistake, I will update.