DPDK patches and discussions
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: David Hunt <david.hunt@intel.com>, reshma.pattan@intel.com
Subject: [dpdk-dev] [PATCH 1/2] power: fix power management env detection
Date: Mon, 13 Jul 2020 13:15:58 +0100	[thread overview]
Message-ID: <c568269db57a81ab8fecac06f81c1054f6439100.1594642553.git.anatoly.burakov@intel.com> (raw)

Anything coming from sysfs has a newline at the end. Cut it off before
comparing the strings.

Fixes: 20ab67608a39 ("power: add environment capability probing")

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_power/power_common.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/librte_power/power_common.c b/lib/librte_power/power_common.c
index 59023d986b..fd527719cd 100644
--- a/lib/librte_power/power_common.c
+++ b/lib/librte_power/power_common.c
@@ -15,6 +15,7 @@ int
 cpufreq_check_scaling_driver(const char *driver_name)
 {
 	unsigned int lcore_id = 0; /* always check core 0 */
+	size_t len;
 	char fullpath[PATH_MAX];
 	char readbuf[PATH_MAX];
 	char *s;
@@ -39,6 +40,10 @@ cpufreq_check_scaling_driver(const char *driver_name)
 	if (s == NULL)
 		return 0;
 
+	/* when read from sysfs, driver name has an extra newline at the end */
+	len = strnlen(readbuf, sizeof(readbuf));
+	readbuf[len - 1] = '\0';
+
 	/* does the driver name match? */
 	if (strncmp(readbuf, driver_name, sizeof(readbuf)) != 0)
 		return 0;
-- 
2.17.1

             reply	other threads:[~2020-07-13 12:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 12:15 Anatoly Burakov [this message]
2020-07-13 12:15 ` [dpdk-dev] [PATCH 2/2] l3fwd-power: fix updating performance lcore parameters Anatoly Burakov
2020-07-13 12:29   ` Hunt, David
2020-07-13 12:26 ` [dpdk-dev] [PATCH 1/2] power: fix power management env detection Hunt, David
2020-07-13 14:54 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov
2020-07-13 15:33   ` Bruce Richardson
2020-07-14  9:34     ` Burakov, Anatoly
2020-07-14 10:30   ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2020-07-15  4:18     ` Ma, LihongX
2020-07-17 12:50     ` Bruce Richardson
2020-07-21 23:57       ` Thomas Monjalon
2020-07-14 10:30   ` [dpdk-dev] [PATCH v3 2/2] l3fwd-power: fix updating performance lcore parameters Anatoly Burakov
2020-07-13 14:54 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c568269db57a81ab8fecac06f81c1054f6439100.1594642553.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).