DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Alejandro Lucero <alejandro.lucero@netronome.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Declan Doherty <declan.doherty@intel.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Jing Chen <jing.d.chen@intel.com>,
	John Miller <john.miller@atomicrules.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Matt Peters <matt.peters@windriver.com>,
	Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
	Pascal Mazon <pascal.mazon@6wind.com>,
	Shrikrishna Khare <skhare@vmware.com>,
	Srisivasubramanian Srinivasan <ssrinivasan@cavium.com>,
	Tetsuya Mukawa <mtetsuyah@gmail.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Yongseok Koh <yskoh@mellanox.com>
Subject: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE
Date: Tue, 24 Oct 2017 12:35:36 +0200	[thread overview]
Message-ID: <cover.1508840456.git.gaetan.rivet@6wind.com> (raw)
In-Reply-To: <cover.1508833643.git.gaetan.rivet@6wind.com>

This flag was deprecated in the previous release, and this is its removal.

We are going from an explicit support of device detach, to an implicit one,
with specific checks in place for PMDs not supporting the feature.

Attempting to Cc all relevant maintainers:

Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: Beilei Xing <beilei.xing@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: Declan Doherty <declan.doherty@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jing Chen <jing.d.chen@intel.com>
Cc: John Miller <john.miller@atomicrules.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: Matt Peters <matt.peters@windriver.com>
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: Pascal Mazon <pascal.mazon@6wind.com>
Cc: Shrikrishna Khare <skhare@vmware.com>
Cc: Srisivasubramanian Srinivasan <ssrinivasan@cavium.com>
Cc: Tetsuya Mukawa <mtetsuyah@gmail.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: Yongseok Koh <yskoh@mellanox.com>

Sorry for any undue ML traffic going your way if you are not interested
in this series.

I'd like to highlight Alejandro Lucero for the NFP PMD, as the patch is
somewhat more involved for this PMD and I don't have the hardware available
to validate the change.

v2:

  + Split ether patch:
    First remove the use of the flag, then remove the flag

  + Restore RTE_ETH_DEV_BONDED_SLAVE check,
    previously hastily removed along the DETACHABLE one.

  + Added release note, removed deprecation notice

Gaetan Rivet (6):
  ethdev: do not rely on detachable flag in detach
  ethdev: remove detachable device flag
  pci: propagate PMD removal error value for unplug
  doc: follow detachable flag disappearance
  doc: update detachable flag deprecation notice
  doc: note ether API change for detachable flag

 doc/guides/prog_guide/port_hotplug_framework.rst |  8 ++------
 doc/guides/rel_notes/deprecation.rst             |  8 --------
 doc/guides/rel_notes/release_17_11.rst           |  6 ++++++
 drivers/net/af_packet/rte_eth_af_packet.c        |  1 -
 drivers/net/ark/ark_ethdev.c                     |  1 -
 drivers/net/avp/avp_ethdev.c                     |  2 --
 drivers/net/bnxt/bnxt_ethdev.c                   |  1 -
 drivers/net/bonding/rte_eth_bond_pmd.c           |  3 +--
 drivers/net/e1000/em_ethdev.c                    |  1 -
 drivers/net/e1000/igb_ethdev.c                   |  2 --
 drivers/net/fm10k/fm10k_ethdev.c                 |  1 -
 drivers/net/i40e/i40e_ethdev.c                   |  1 -
 drivers/net/i40e/i40e_ethdev_vf.c                |  1 -
 drivers/net/ixgbe/ixgbe_ethdev.c                 |  2 --
 drivers/net/kni/rte_eth_kni.c                    |  2 --
 drivers/net/liquidio/lio_ethdev.c                |  1 -
 drivers/net/mlx4/mlx4.c                          |  1 -
 drivers/net/mlx5/mlx5.c                          |  1 -
 drivers/net/nfp/nfp_net.c                        | 19 ++++++++++++++---
 drivers/net/null/rte_eth_null.c                  |  2 --
 drivers/net/pcap/rte_eth_pcap.c                  |  1 -
 drivers/net/ring/rte_eth_ring.c                  |  1 -
 drivers/net/sfc/sfc_ethdev.c                     |  2 --
 drivers/net/softnic/rte_eth_softnic.c            |  1 -
 drivers/net/tap/rte_eth_tap.c                    |  2 +-
 drivers/net/vhost/rte_eth_vhost.c                |  3 +--
 drivers/net/virtio/virtio_ethdev.c               |  1 -
 drivers/net/virtio/virtio_user_ethdev.c          |  1 -
 drivers/net/vmxnet3/vmxnet3_ethdev.c             |  1 -
 lib/librte_eal/common/eal_common_pci.c           | 14 +++++++++----
 lib/librte_ether/rte_ethdev.c                    | 26 ++++++++----------------
 lib/librte_ether/rte_ethdev.h                    |  2 --
 32 files changed, 46 insertions(+), 73 deletions(-)

-- 
2.1.4

  parent reply	other threads:[~2017-10-24 10:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24  8:59 [dpdk-dev] [PATCH v1 0/3] " Gaetan Rivet
2017-10-24  8:59 ` [dpdk-dev] [PATCH v1 1/3] ethdev: remove detachable device flag Gaetan Rivet
2017-10-24  9:13   ` Andrew Rybchenko
2017-10-24  9:23   ` Thomas Monjalon
2017-10-24  9:27     ` Gaëtan Rivet
2017-10-24  8:59 ` [dpdk-dev] [PATCH v1 2/3] doc: follow detachable flag disappearance Gaetan Rivet
2017-10-25  8:55   ` Mcnamara, John
2017-10-25  8:56   ` Mcnamara, John
2017-10-24  8:59 ` [dpdk-dev] [PATCH v1 3/3] pci: propagate PMD removal error value for unplug Gaetan Rivet
2017-10-24 10:35 ` Gaetan Rivet [this message]
2017-10-24 10:35   ` [dpdk-dev] [PATCH v2 1/6] ethdev: do not rely on detachable flag in detach Gaetan Rivet
2017-10-24 10:35     ` [dpdk-dev] [PATCH v2 2/6] ethdev: remove detachable device flag Gaetan Rivet
2017-10-24 10:35     ` [dpdk-dev] [PATCH v2 3/6] pci: propagate PMD removal error value for unplug Gaetan Rivet
2017-10-24 10:35     ` [dpdk-dev] [PATCH v2 4/6] doc: follow detachable flag disappearance Gaetan Rivet
2017-10-25  8:57       ` Mcnamara, John
2017-10-24 10:35     ` [dpdk-dev] [PATCH v2 5/6] doc: update detachable flag deprecation notice Gaetan Rivet
2017-10-25  9:03       ` Mcnamara, John
2017-10-24 10:35     ` [dpdk-dev] [PATCH v2 6/6] doc: note ether API change for detachable flag Gaetan Rivet
2017-10-25  8:58       ` Mcnamara, John
2017-10-25  9:01       ` Mcnamara, John
2017-10-24 12:35   ` [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE Thomas Monjalon
2017-10-25 17:37     ` Ferruh Yigit
2017-10-30  9:45       ` Alejandro Lucero
2017-10-31 11:09         ` Alejandro Lucero
2017-10-31 17:24           ` Ferruh Yigit
2017-10-24 23:56   ` Ferruh Yigit
2017-10-25 16:11     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1508840456.git.gaetan.rivet@6wind.com \
    --to=gaetan.rivet@6wind.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jing.d.chen@intel.com \
    --cc=john.miller@atomicrules.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=linville@tuxdriver.com \
    --cc=matt.peters@windriver.com \
    --cc=mtetsuyah@gmail.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=pascal.mazon@6wind.com \
    --cc=skhare@vmware.com \
    --cc=ssrinivasan@cavium.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).