From: Andrew Rybchenko <arybchenko@solarflare.com> To: "Guo, Jia" <jia.guo@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, "Somnath Kotur" <somnath.kotur@broadcom.com>, Ziyang Xuan <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>, Guoyang Zhou <zhouguoyang@huawei.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support Date: Wed, 21 Oct 2020 19:12:12 +0300 Message-ID: <feb41af0-2acb-63f8-5523-ba3f3b28c97c@solarflare.com> (raw) In-Reply-To: <0d1111bea4a045bfa57c558151f8d158@intel.com> On 10/21/20 8:38 AM, Guo, Jia wrote: > >> -----Original Message----- >> From: Andrew Rybchenko <arybchenko@solarflare.com> >> Sent: Sunday, October 18, 2020 10:09 PM >> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei >> <beilei.xing@intel.com>; Iremonger, Bernard >> <bernard.iremonger@intel.com>; Ray Kinsella <mdr@ashroe.eu>; Neil >> Horman <nhorman@tuxdriver.com>; Ajit Khaparde >> <ajit.khaparde@broadcom.com>; Somnath Kotur >> <somnath.kotur@broadcom.com>; Guo, Jia <jia.guo@intel.com>; Wang, >> Haiyue <haiyue.wang@intel.com>; Ziyang Xuan >> <xuanziyang2@huawei.com>; Xiaoyun Wang >> <cloud.wangxiaoyun@huawei.com>; Guoyang Zhou >> <zhouguoyang@huawei.com>; Rasesh Mody <rmody@marvell.com>; >> Shahed Shaikh <shshaikh@marvell.com>; Andrew Rybchenko >> <andrew.rybchenko@oktetlabs.ru>; Thomas Monjalon >> <thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com> >> Cc: dev@dpdk.org >> Subject: [PATCH 03/14] ethdev: remove legacy EtherType filter type support >> >> RTE flow API should be used for filtering. >> >> Move corresponding definitions to ethdev internal driver API since it is used >> by drivers internally. >> Preserve RTE_ETH_FILTER_ETHERTYPE because of it as well. >> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> >> --- >> app/test-pmd/cmdline.c | 115 ------------------- >> doc/guides/rel_notes/deprecation.rst | 2 +- >> drivers/net/bnxt/bnxt_ethdev.c | 157 -------------------------- >> drivers/net/e1000/igb_ethdev.c | 85 -------------- >> drivers/net/hinic/hinic_pmd_ethdev.h | 1 + >> drivers/net/i40e/i40e_ethdev.c | 45 -------- >> drivers/net/ixgbe/ixgbe_ethdev.c | 85 -------------- >> drivers/net/qede/qede_filter.c | 1 - >> drivers/net/sfc/sfc_ethdev.c | 3 - >> lib/librte_ethdev/rte_eth_ctrl.h | 19 ---- >> lib/librte_ethdev/rte_ethdev_driver.h | 23 ++++ >> 11 files changed, 25 insertions(+), 511 deletions(-) >> > > <...> > >> #define RTE_FLEX_FILTER_MAXLEN128/**< bytes to use in flex filter. */ >> #define RTE_FLEX_FILTER_MASK_SIZE\ >> (RTE_ALIGN(RTE_FLEX_FILTER_MAXLEN, CHAR_BIT) / CHAR_BIT) diff --git >> a/lib/librte_ethdev/rte_ethdev_driver.h >> b/lib/librte_ethdev/rte_ethdev_driver.h >> index c63b9f7eb7..67a83dacc7 100644 >> --- a/lib/librte_ethdev/rte_ethdev_driver.h >> +++ b/lib/librte_ethdev/rte_ethdev_driver.h >> @@ -1342,6 +1342,29 @@ int >> rte_eth_hairpin_queue_peer_unbind(uint16_t cur_port, uint16_t >> cur_queue, >> uint32_t direction); >> >> + >> +/* > > s/*/** No, it is not going to be a comment picked up by doxygen. Otherwise it requires @group mark up etc which is not used in DPDK as far as I know. >> + * Legacy ethdev API used internally by drivers. >> + */ >> + > > I am not sure if this doc is need? I think it is required to highlight that it is legacy and should not be used by new drivers. >> +/** >> + * Define all structures for Ethertype Filter type. >> + */ >> + >> +#define RTE_ETHTYPE_FLAGS_MAC 0x0001 /**< If set, compare mac */ >> +#define RTE_ETHTYPE_FLAGS_DROP 0x0002 /**< If set, drop packet when >> match */ >> + >> +/** >> + * A structure used to define the ethertype filter entry >> + * to support RTE_ETH_FILTER_ETHERTYPE data representation. >> + */ >> +struct rte_eth_ethertype_filter { >> +struct rte_ether_addr mac_addr; /**< Mac address to match. */ >> +uint16_t ether_type; /**< Ether type to match */ >> +uint16_t flags; /**< Flags from RTE_ETHTYPE_FLAGS_* */ >> +uint16_t queue; /**< Queue assigned to when match*/ >> +}; >> + >> #ifdef __cplusplus >> } >> #endif >> -- >> 2.17.1 >> >
next prev parent reply other threads:[~2020-10-21 16:12 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-18 14:08 [dpdk-dev] [PATCH 00/14] ethdev: remove legacy filter API Andrew Rybchenko 2020-10-18 14:08 ` [dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support Andrew Rybchenko 2020-10-20 11:07 ` David Marchand 2020-10-21 16:34 ` Andrew Rybchenko 2020-10-21 3:31 ` Guo, Jia 2020-10-21 16:05 ` Andrew Rybchenko 2020-10-22 1:59 ` Guo, Jia 2020-10-18 14:08 ` [dpdk-dev] [PATCH 02/14] ethdev: move MAC filter type to i40e driver Andrew Rybchenko 2020-10-21 4:01 ` Guo, Jia 2020-10-21 16:09 ` Andrew Rybchenko 2020-10-22 2:58 ` Guo, Jia 2020-10-22 7:19 ` Andrew Rybchenko 2020-10-18 14:09 ` [dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support Andrew Rybchenko 2020-10-18 22:13 ` Ajit Khaparde 2020-10-19 6:40 ` Wang, Haiyue [not found] ` <BYAPR11MB3493BE2EB0D5B91DDDCD99758C1C0@BYAPR11MB3493.namprd11.prod.outlook.com> 2020-10-21 5:38 ` Guo, Jia 2020-10-21 16:12 ` Andrew Rybchenko [this message] 2020-10-18 14:09 ` [dpdk-dev] [PATCH 04/14] ethdev: remove legacy flexible " Andrew Rybchenko 2020-10-19 6:29 ` Wang, Haiyue 2020-10-18 14:09 ` [dpdk-dev] [PATCH 05/14] ethdev: move flexible filter type to e1000 driver Andrew Rybchenko 2020-10-19 6:20 ` Wang, Haiyue 2020-10-18 14:09 ` [dpdk-dev] [PATCH 06/14] ethdev: remove legacy SYN filter type support Andrew Rybchenko 2020-10-19 6:45 ` Wang, Haiyue 2020-10-18 14:09 ` [dpdk-dev] [PATCH 07/14] ethdev: remove legacy N-tuple " Andrew Rybchenko 2020-10-18 22:13 ` Ajit Khaparde 2020-10-19 6:47 ` Wang, Haiyue 2020-10-18 14:09 ` [dpdk-dev] [PATCH 08/14] ethdev: remove legacy TUNNEL " Andrew Rybchenko 2020-10-18 22:14 ` Ajit Khaparde 2020-10-19 8:01 ` Li, Xiaoyun 2020-10-18 14:09 ` [dpdk-dev] [PATCH 09/14] ethdev: remove legacy HASH " Andrew Rybchenko 2020-10-18 14:09 ` [dpdk-dev] [PATCH 10/14] ethdev: remove legacy L2_TUNNEL " Andrew Rybchenko 2020-10-19 6:42 ` Wang, Haiyue 2020-10-18 14:09 ` [dpdk-dev] [PATCH 11/14] ethdev: remove legacy global filter configuration support Andrew Rybchenko 2020-10-21 5:42 ` Guo, Jia 2020-10-18 14:09 ` [dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support Andrew Rybchenko 2020-10-18 22:15 ` Ajit Khaparde 2020-10-19 6:53 ` Wang, Haiyue 2020-10-21 5:45 ` Guo, Jia 2020-10-21 16:17 ` Andrew Rybchenko 2020-10-22 2:45 ` Guo, Jia 2020-10-18 14:09 ` [dpdk-dev] [PATCH 13/14] app/testpmd: remove flow_director_flex_mask command Andrew Rybchenko 2020-10-20 10:53 ` David Marchand 2020-10-22 9:01 ` Andrew Rybchenko 2020-10-18 14:09 ` [dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions Andrew Rybchenko 2020-10-20 10:47 ` David Marchand 2020-10-20 14:52 ` Ferruh Yigit 2020-10-22 9:12 ` Andrew Rybchenko 2020-10-22 9:33 ` Ferruh Yigit 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 00/14] ethdev: remove legacy filter API Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 01/14] ethdev: remove legacy MACVLAN filter type support Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 02/14] ethdev: move MAC filter type to i40e driver Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 03/14] ethdev: remove legacy EtherType filter type support Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 04/14] ethdev: remove legacy flexible " Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 05/14] ethdev: move flexible filter type to e1000 driver Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 06/14] ethdev: remove legacy SYN filter type support Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 07/14] ethdev: remove legacy N-tuple " Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 08/14] ethdev: remove legacy TUNNEL " Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 09/14] ethdev: remove legacy HASH " Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 10/14] ethdev: remove legacy L2_TUNNEL " Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 11/14] ethdev: remove legacy global filter configuration support Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 12/14] ethdev: remove legacy FDIR filter type support Andrew Rybchenko 2020-10-23 3:32 ` Hyong Youb Kim (hyonkim) 2020-10-23 6:41 ` Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 13/14] app/testpmd: remove command to set FDIR flexible filter mask Andrew Rybchenko 2020-10-22 9:42 ` [dpdk-dev] [PATCH v2 14/14] ethdev: remove legacy filter API functions Andrew Rybchenko 2020-10-23 16:03 ` [dpdk-dev] [PATCH v2 00/14] ethdev: remove legacy filter API Ferruh Yigit 2020-10-29 21:36 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=feb41af0-2acb-63f8-5523-ba3f3b28c97c@solarflare.com \ --to=arybchenko@solarflare.com \ --cc=ajit.khaparde@broadcom.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=cloud.wangxiaoyun@huawei.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jia.guo@intel.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=rmody@marvell.com \ --cc=shshaikh@marvell.com \ --cc=somnath.kotur@broadcom.com \ --cc=thomas@monjalon.net \ --cc=wenzhuo.lu@intel.com \ --cc=xuanziyang2@huawei.com \ --cc=zhouguoyang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git