test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] Add m flag to tar command
@ 2021-06-07 13:56 blo
  2021-06-07 15:09 ` [dts] [PATCH v2] " blo
  0 siblings, 1 reply; 4+ messages in thread
From: blo @ 2021-06-07 13:56 UTC (permalink / raw)
  To: dts; +Cc: Brandon Lo

From: Brandon Lo <blo@iol.unh.edu>

The m flag for tar makes it so that the untar process touches
each file. This will prevent any time presevation issues like
clock skew.
---
 framework/project_dpdk.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 2975e2ef..f7946664 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -462,7 +462,7 @@ class DPDKdut(Dut):
             self.send_expect("rm -rf %s" % self.base_dir, "#")
 
             # unpack dpdk
-            out = self.send_expect("tar zxf %s%s -C %s" %
+            out = self.send_expect("tar zxfm %s%s -C %s" %
                                    (dst_dir, self.package.split('/')[-1], p_dir),
                                    "# ", 30, verify=True)
             if out == -1:
@@ -704,10 +704,10 @@ class DPDKtester(Tester):
             self.session.copy_file_to("dep/tgen.tgz")
             self.session.copy_file_to("dep/tclclient.tgz")
             # unpack tgen
-            out = self.send_expect("tar zxf tgen.tgz", "# ")
+            out = self.send_expect("tar zxfm tgen.tgz", "# ")
             assert "Error" not in out
             # unpack tclclient
-            out = self.send_expect("tar zxf tclclient.tgz", "# ")
+            out = self.send_expect("tar zxfm tclclient.tgz", "# ")
             assert "Error" not in out
 
         self.send_expect("modprobe uio", "# ")
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH v2] Add m flag to tar command
  2021-06-07 13:56 [dts] [PATCH] Add m flag to tar command blo
@ 2021-06-07 15:09 ` blo
  0 siblings, 0 replies; 4+ messages in thread
From: blo @ 2021-06-07 15:09 UTC (permalink / raw)
  To: dts; +Cc: Brandon Lo

From: Brandon Lo <blo@iol.unh.edu>

The m flag for tar makes it so that the untar process touches
each file. This will prevent any time presevation issues like
clock skew.

Signed-off-by: Brandon Lo <blo@iol.unh.edu>
---
 framework/project_dpdk.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 2975e2ef..f7946664 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -462,7 +462,7 @@ class DPDKdut(Dut):
             self.send_expect("rm -rf %s" % self.base_dir, "#")
 
             # unpack dpdk
-            out = self.send_expect("tar zxf %s%s -C %s" %
+            out = self.send_expect("tar zxfm %s%s -C %s" %
                                    (dst_dir, self.package.split('/')[-1], p_dir),
                                    "# ", 30, verify=True)
             if out == -1:
@@ -704,10 +704,10 @@ class DPDKtester(Tester):
             self.session.copy_file_to("dep/tgen.tgz")
             self.session.copy_file_to("dep/tclclient.tgz")
             # unpack tgen
-            out = self.send_expect("tar zxf tgen.tgz", "# ")
+            out = self.send_expect("tar zxfm tgen.tgz", "# ")
             assert "Error" not in out
             # unpack tclclient
-            out = self.send_expect("tar zxf tclclient.tgz", "# ")
+            out = self.send_expect("tar zxfm tclclient.tgz", "# ")
             assert "Error" not in out
 
         self.send_expect("modprobe uio", "# ")
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH v2] Add m flag to tar command
  2021-06-07 15:07 blo
@ 2021-06-09  8:09 ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-06-09  8:09 UTC (permalink / raw)
  To: blo, dts


> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of blo@iol.unh.edu
> Sent: 2021年6月7日 23:08
> To: dts@dpdk.org
> Cc: Brandon Lo <blo@iol.unh.edu>
> Subject: [dts] [PATCH v2] Add m flag to tar command
> 
> From: Brandon Lo <blo@iol.unh.edu>
> 
> The m flag for tar makes it so that the untar process touches each file. This will
> prevent any time presevation issues like clock skew.
> 
> Signed-off-by: Brandon Lo <blo@iol.unh.edu>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH v2] Add m flag to tar command
@ 2021-06-07 15:07 blo
  2021-06-09  8:09 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: blo @ 2021-06-07 15:07 UTC (permalink / raw)
  To: dts; +Cc: Brandon Lo

From: Brandon Lo <blo@iol.unh.edu>

The m flag for tar makes it so that the untar process touches
each file. This will prevent any time presevation issues like
clock skew.

Signed-off-by: Brandon Lo <blo@iol.unh.edu>
---
 framework/project_dpdk.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 2975e2ef..f7946664 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -462,7 +462,7 @@ class DPDKdut(Dut):
             self.send_expect("rm -rf %s" % self.base_dir, "#")
 
             # unpack dpdk
-            out = self.send_expect("tar zxf %s%s -C %s" %
+            out = self.send_expect("tar zxfm %s%s -C %s" %
                                    (dst_dir, self.package.split('/')[-1], p_dir),
                                    "# ", 30, verify=True)
             if out == -1:
@@ -704,10 +704,10 @@ class DPDKtester(Tester):
             self.session.copy_file_to("dep/tgen.tgz")
             self.session.copy_file_to("dep/tclclient.tgz")
             # unpack tgen
-            out = self.send_expect("tar zxf tgen.tgz", "# ")
+            out = self.send_expect("tar zxfm tgen.tgz", "# ")
             assert "Error" not in out
             # unpack tclclient
-            out = self.send_expect("tar zxf tclclient.tgz", "# ")
+            out = self.send_expect("tar zxfm tclclient.tgz", "# ")
             assert "Error" not in out
 
         self.send_expect("modprobe uio", "# ")
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-09  8:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07 13:56 [dts] [PATCH] Add m flag to tar command blo
2021-06-07 15:09 ` [dts] [PATCH v2] " blo
2021-06-07 15:07 blo
2021-06-09  8:09 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).