From: Rami Rosen <ramirose@gmail.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo
Date: Fri, 12 Apr 2019 20:24:52 +0300 [thread overview]
Message-ID: <CAHLOa7S3k=2ET+rgqGfZ-1e_7p3EBJc0onLE3M9YM4v_imo+sA@mail.gmail.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA60CA4@SHSMSX101.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1748 bytes --]
Hi, Lijuan,
I see now what you mean now. Well, i do not know all nuances
of grammer, and sometimes there is more than one rule.
I think "creating a RSS rule" is not wrong, but
I remember I encountered in the past "creating an RSS rule", for example:
https://patches.dpdk.org/patch/47790/
http://patchwork.dpdk.org/patch/34609/
Maybe i even used something like this in my book, can't remember :)
But this is really minor.
I will send v2 with "a RSS rule".
Regards,
Rami Rosen
בתאריך יום ו׳, 12 באפר׳ 2019, 19:55, מאת Tu, Lijuan <lijuan.tu@intel.com>:
> Mess up again.
>
> I think r is consonant, so we take an “a” before it , not an “an”, so
> “Create a rss rult with” should be “Create a rss rule with”
>
>
>
>
>
> *From:* dts [mailto:dts-bounces@dpdk.org] *On Behalf Of *Tu, Lijuan
> *Sent:* Friday, April 12, 2019 9:50 AM
> *To:* Rami Rosen <ramirose@gmail.com>
> *Cc:* dts@dpdk.org
> *Subject:* Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo
>
>
>
> I think r is consonant, so we take an “an” before it , not an “a”, so
> “Create a rss rult with” should be “Create a rss rule with”
>
>
>
> *From:* Rami Rosen [mailto:ramirose@gmail.com <ramirose@gmail.com>]
> *Sent:* Friday, April 12, 2019 9:45 AM
> *To:* Tu, Lijuan <lijuan.tu@intel.com>
> *Cc:* dts@dpdk.org
> *Subject:* Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo
>
>
>
> Hi Lijuan,
>
>
>
> In the code we have:
>
> >> Create a rss rult with
>
>
>
> >I think it is a rss rule
>
>
>
> Not sure what you mean by this. Is "rult" an rss rule ? This seems more
> like a typo (that the patch fixes)
>
>
>
> Regards,
>
> Rami Rosen
>
>
>
[-- Attachment #2: Type: text/html, Size: 5916 bytes --]
prev parent reply other threads:[~2019-04-12 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 7:38 Rami Rosen
2019-04-12 16:29 ` Tu, Lijuan
2019-04-12 16:44 ` Rami Rosen
2019-04-12 16:50 ` Tu, Lijuan
2019-04-12 16:55 ` Tu, Lijuan
2019-04-12 17:24 ` Rami Rosen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHLOa7S3k=2ET+rgqGfZ-1e_7p3EBJc0onLE3M9YM4v_imo+sA@mail.gmail.com' \
--to=ramirose@gmail.com \
--cc=dts@dpdk.org \
--cc=lijuan.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).