[dts] [PATCH] tests/rss_to_rte_flow: fix a typo

[dts] [PATCH] tests/rss_to_rte_flow: fix a typo

[Rami Rosen]

This patch fixes a typo in RSS to rte_flow test module:
a rss rult=>an rss rule

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 tests/TestSuite_rss_to_rte_flow.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_rss_to_rte_flow.py b/tests/TestSuite_rss_to_rte_flow.py
index 12c13e7..0053c12 100644
--- a/tests/TestSuite_rss_to_rte_flow.py
+++ b/tests/TestSuite_rss_to_rte_flow.py
@@ -436,7 +436,7 @@ class TestRSS_to_Rteflow(TestCase):
 
         self.verify((key in out2) and (out1 != out2) and (list1 != list2), "the key setting doesn't take effect.")
 
-        # Create a rss rult with truncating key_len
+        # Create an rss rule with truncating key_len
         self.dut.send_expect("flow flush 0", "testpmd> ")
         key = "1234567890123456789012345678901234567890FFFFFFFFFFFF1234567890123456789012345678901234567890FFFFFFFFFFFF"
         key_len = "50"
-- 
2.19.2

Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo

[Tu, Lijuan]

Hi Rami,

I think it is a rss rule

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Friday, April 12, 2019 12:39 AM
> To: dts@dpdk.org
> Cc: Rami Rosen <ramirose@gmail.com>
> Subject: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo
> 
> This patch fixes a typo in RSS to rte_flow test module:
> a rss rult=>an rss rule
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  tests/TestSuite_rss_to_rte_flow.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_rss_to_rte_flow.py
> b/tests/TestSuite_rss_to_rte_flow.py
> index 12c13e7..0053c12 100644
> --- a/tests/TestSuite_rss_to_rte_flow.py
> +++ b/tests/TestSuite_rss_to_rte_flow.py
> @@ -436,7 +436,7 @@ class TestRSS_to_Rteflow(TestCase):
> 
>          self.verify((key in out2) and (out1 != out2) and (list1 != list2), "the key
> setting doesn't take effect.")
> 
> -        # Create a rss rult with truncating key_len
> +        # Create an rss rule with truncating key_len
>          self.dut.send_expect("flow flush 0", "testpmd> ")
>          key =
> "1234567890123456789012345678901234567890FFFFFFFFFFFF1234567890123
> 456789012345678901234567890FFFFFFFFFFFF"
>          key_len = "50"
> --
> 2.19.2

Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

Hi Lijuan,

In the code we have:
   >> Create a rss rult with

>I think it is a rss rule

Not sure what you mean by this. Is "rult" an rss rule ? This seems more
like a typo (that the patch fixes)

Regards,
Rami Rosen

[-- Attachment #2: Type: text/html, Size: 939 bytes --]

Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo

[Tu, Lijuan]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

I think r is consonant, so we take an “an” before it , not an “a”, so “Create a rss rult with” should be “Create a rss rule with”

From: Rami Rosen [mailto:ramirose@gmail.com]
Sent: Friday, April 12, 2019 9:45 AM
To: Tu, Lijuan <lijuan.tu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo

Hi Lijuan,

In the code we have:
   >> Create a rss rult with

>I think it is a rss rule

Not sure what you mean by this. Is "rult" an rss rule ? This seems more like a typo (that the patch fixes)

Regards,
Rami Rosen


[-- Attachment #2: Type: text/html, Size: 4175 bytes --]

Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo

[Tu, Lijuan]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

Mess up again.
I think r is consonant, so we take an “a” before it , not an “an”, so “Create a rss rult with” should be “Create a rss rule with”


From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
Sent: Friday, April 12, 2019 9:50 AM
To: Rami Rosen <ramirose@gmail.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo

I think r is consonant, so we take an “an” before it , not an “a”, so “Create a rss rult with” should be “Create a rss rule with”

From: Rami Rosen [mailto:ramirose@gmail.com]
Sent: Friday, April 12, 2019 9:45 AM
To: Tu, Lijuan <lijuan.tu@intel.com<mailto:lijuan.tu@intel.com>>
Cc: dts@dpdk.org<mailto:dts@dpdk.org>
Subject: Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo

Hi Lijuan,

In the code we have:
   >> Create a rss rult with

>I think it is a rss rule

Not sure what you mean by this. Is "rult" an rss rule ? This seems more like a typo (that the patch fixes)

Regards,
Rami Rosen


[-- Attachment #2: Type: text/html, Size: 5802 bytes --]

Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 1748 bytes --]

Hi, Lijuan,

I see  now what you mean now. Well, i do not know all nuances
 of grammer, and sometimes there is more than one rule.
I think "creating a RSS rule" is not wrong, but
I remember I encountered in the past "creating an RSS rule", for example:

https://patches.dpdk.org/patch/47790/
http://patchwork.dpdk.org/patch/34609/

Maybe i even used something like this in my book, can't remember :)

But this is really minor.
I will send v2 with "a RSS rule".

Regards,
Rami Rosen




בתאריך יום ו׳, 12 באפר׳ 2019, 19:55, מאת Tu, Lijuan ‏<lijuan.tu@intel.com>:

> Mess up again.
>
> I think r is consonant, so we take an “a” before it , not an “an”, so
> “Create a rss rult with” should be “Create a rss rule with”
>
>
>
>
>
> *From:* dts [mailto:dts-bounces@dpdk.org] *On Behalf Of *Tu, Lijuan
> *Sent:* Friday, April 12, 2019 9:50 AM
> *To:* Rami Rosen <ramirose@gmail.com>
> *Cc:* dts@dpdk.org
> *Subject:* Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo
>
>
>
> I think r is consonant, so we take an “an” before it , not an “a”, so
> “Create a rss rult with” should be “Create a rss rule with”
>
>
>
> *From:* Rami Rosen [mailto:ramirose@gmail.com <ramirose@gmail.com>]
> *Sent:* Friday, April 12, 2019 9:45 AM
> *To:* Tu, Lijuan <lijuan.tu@intel.com>
> *Cc:* dts@dpdk.org
> *Subject:* Re: [dts] [PATCH] tests/rss_to_rte_flow: fix a typo
>
>
>
> Hi Lijuan,
>
>
>
> In the code we have:
>
>    >> Create a rss rult with
>
>
>
> >I think it is a rss rule
>
>
>
> Not sure what you mean by this. Is "rult" an rss rule ? This seems more
> like a typo (that the patch fixes)
>
>
>
> Regards,
>
> Rami Rosen
>
>
>

[-- Attachment #2: Type: text/html, Size: 5916 bytes --]