Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063

[Narala Praneeth Reddy <nareddy@marvell.com>]

[-- Attachment #1: Type: text/plain, Size: 6276 bytes --]




________________________________
From: Tu, Lijuan <lijuan.tu@intel.com>
Sent: Wednesday, April 24, 2019 10:01 PM
To: Narala Praneeth Reddy; dts@dpdk.org
Cc: Faisal Masood; Vijaya Bhaskar Annayyolla
Subject: RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063






From: Narala Praneeth Reddy [mailto:nareddy@marvell.com]
Sent: Wednesday, April 24, 2019 4:27 AM
To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
Cc: Faisal Masood <fmasood@marvell.com>; Vijaya Bhaskar Annayyolla <avijay@marvell.com>
Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063



Please find inline comments.



________________________________

From: Tu, Lijuan <lijuan.tu@intel.com<mailto:lijuan.tu@intel.com>>
Sent: Wednesday, April 24, 2019 1:10 AM
To: Narala Praneeth Reddy; dts@dpdk.org<mailto:dts@dpdk.org>
Cc: Faisal Masood; Vijaya Bhaskar Annayyolla
Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063



External Email

----------------------------------------------------------------------


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com<mailto:nareddy@marvell.com>
> Sent: Monday, April 22, 2019 10:24 PM
> To: dts@dpdk.org<mailto:dts@dpdk.org>
> Cc: fmasood@marvell.com<mailto:fmasood@marvell.com>; avijay@marvell.com<mailto:avijay@marvell.com>; Praneeth Reddy
> <nareddy@marvell.com<mailto:nareddy@marvell.com>>
> Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype
> mapping is not supported for cavium_a063
>
> From: Praneeth Reddy <nareddy@marvell.com<mailto:nareddy@marvell.com>>
>
> Marking this test case as not applicable for cavium_a063
>
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com<mailto:nareddy@marvell.com>>
> ---
>  conf/test_case_checklist.json    | 62
> +++++++++++++++++++++++++++++++++++++++-
>  tests/TestSuite_ptype_mapping.py |  2 +-
>  2 files changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index a1aa90b..decc946 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2200,5 +2200,65 @@
>              "Bug ID": "",
>              "Comments": "the nic not support this case"
>          }
> -    ]
> +    ],
> +     "ptype_mapping_get": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_replace": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_reset": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_update": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
> +     ]
>  }
> diff --git a/tests/TestSuite_ptype_mapping.py
> b/tests/TestSuite_ptype_mapping.py
> index 2771337..6e1fce1 100644
> --- a/tests/TestSuite_ptype_mapping.py
> +++ b/tests/TestSuite_ptype_mapping.py
> @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase):
>          Run at the start of each test suite.
>          """
>          self.verify(self.nic in ['fortville_eagle', 'fortville_spirit',
> -            'fortville_spirit_single', 'fortville_25g'],
> +            'fortville_spirit_single', 'fortville_25g', 'cavium_a063'],
[Lijuan] The NIC in the list above means support these cases. But from other context, Cavium_a063 does not support ptype mapping, Did I miss anything?

[Praneeth] ptype_mapping test case get FAIL and mention NIC not supported whenever complete DTS test suite ran for cavium_a063, inorder to make this test case as N/A, did following changes.
                              1. Added cavium_a063 to support list in TestSuite_ptype_mapping.py, so that ptype_mapping test cases doesn't get fails and moves to next step.
                              2. Later as I added all ptype_mapping test cases in test_case_checklist.json, ptype_mapping test cases gets skip without executing. Finally the result will be N/A instead of FAIL.
                       Is this right way? Is there any other procedure to mark this test case as N/A for cavium_a063.

[Lijuan] it’s the right way to leverage item 2 to skip the test cases if your NIC not support them. Cavium_a063 does not support ptype mapping, so it should not be added in the support list in TestSuite_ptype_mapping.py, that’s why you get failure. If the cases don’t be added in checklist, it will go to test cases which including the verify statement, otherwise it will skip the test cases.

That’s why you get what you want when you tried item 2, but it doesn’t mean we could use item 1 improperly. Remove item 1 and keep item 2 is suitable for your purpose.

[Praneeth] Ok thanks, for not supported test cases we will skip the test case.

>              'ptype mapping test can not support %s nic' % self.nic)
>          ports = self.dut.get_ports()
>          self.verify(len(ports) >= 1, "Insufficient ports for testing")
> --
> 1.8.3.1

[-- Attachment #2: Type: text/html, Size: 16637 bytes --]