test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic
  2021-03-05 17:44 [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic Chen Lingli
@ 2021-03-05  9:49 ` Chen, LingliX
  2021-03-10  6:02 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Chen, LingliX @ 2021-03-05  9:49 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

> -----Original Message-----
> From: Chen, LingliX
> Sent: Saturday, March 6, 2021 1:45 AM
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> foxville_nic
> 
 > Signed-off-by: ChenLingli <linglix.chen@intel.com>

Tested-by: Chen Lingli <linglix.chen@intel.com>




[-- Attachment #2: TestPmdrssreta.log --]
[-- Type: application/octet-stream, Size: 252031 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic
@ 2021-03-05 17:44 Chen Lingli
  2021-03-05  9:49 ` Chen, LingliX
  2021-03-10  6:02 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Chen Lingli @ 2021-03-05 17:44 UTC (permalink / raw)
  To: dts; +Cc: ChenLingli

From: ChenLingli <linglix.chen@intel.com>

updated the rx-offloads for foxville_nic

Signed-off-by: ChenLingli <linglix.chen@intel.com>
---
 tests/TestSuite_pmdrssreta.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py
index 4dd3a5a5..09dd2f55 100644
--- a/tests/TestSuite_pmdrssreta.py
+++ b/tests/TestSuite_pmdrssreta.py
@@ -215,8 +215,12 @@ class TestPmdrssreta(TestCase):
                 self.pmdout.start_testpmd(
                     "all", "--rxq=%d --txq=%d --rx-offloads=0x00080000 " % (queue, queue), socket=self.ports_socket)
             else:
-                self.pmdout.start_testpmd(
-                    "all", "--mbcache=128 --rxq=%d --txq=%d --rx-offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
+                if self.nic == 'foxville':
+                    self.pmdout.start_testpmd(
+                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-offloads=0x00032a0f" % (queue, queue), socket=self.ports_socket)
+                else:
+                    self.pmdout.start_testpmd(
+                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
 
             for iptype, rsstype in list(iptypes.items()):
                 self.dut.send_expect("set verbose 8", "testpmd> ")
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic
  2021-03-05 17:44 [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic Chen Lingli
  2021-03-05  9:49 ` Chen, LingliX
@ 2021-03-10  6:02 ` Tu, Lijuan
  2021-03-22  8:40   ` Chen, BoX C
  1 sibling, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2021-03-10  6:02 UTC (permalink / raw)
  To: Chen, LingliX, dts; +Cc: Chen, LingliX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Chen Lingli
> Sent: 2021年3月6日 1:45
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> foxville_nic
> 
> From: ChenLingli <linglix.chen@intel.com>
> 
> updated the rx-offloads for foxville_nic
> 
> Signed-off-by: ChenLingli <linglix.chen@intel.com>
> ---
>  tests/TestSuite_pmdrssreta.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py index
> 4dd3a5a5..09dd2f55 100644
> --- a/tests/TestSuite_pmdrssreta.py
> +++ b/tests/TestSuite_pmdrssreta.py
> @@ -215,8 +215,12 @@ class TestPmdrssreta(TestCase):
>                  self.pmdout.start_testpmd(
>                      "all", "--rxq=%d --txq=%d --rx-offloads=0x00080000 " % (queue,
> queue), socket=self.ports_socket)
>              else:
> -                self.pmdout.start_testpmd(
> -                    "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
> +                if self.nic == 'foxville':
> +                    self.pmdout.start_testpmd(
> +                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> offloads=0x00032a0f" % (queue, queue), socket=self.ports_socket)

What does the offload mean ?

> +                else:
> +                    self.pmdout.start_testpmd(
> +                        "all", "--mbcache=128 --rxq=%d --txq=%d
> + --rx-offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
> 
>              for iptype, rsstype in list(iptypes.items()):
>                  self.dut.send_expect("set verbose 8", "testpmd> ")
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic
  2021-03-10  6:02 ` Tu, Lijuan
@ 2021-03-22  8:40   ` Chen, BoX C
  0 siblings, 0 replies; 4+ messages in thread
From: Chen, BoX C @ 2021-03-22  8:40 UTC (permalink / raw)
  To: Tu, Lijuan, Chen, LingliX, dts, Zhang, AlvinX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Tu, Lijuan
> Sent: March 10, 2021 14:03
> To: Chen, LingliX <linglix.chen@intel.com>; dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: Re: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> foxville_nic
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Chen Lingli
> > Sent: 2021年3月6日 1:45
> > To: dts@dpdk.org
> > Cc: Chen, LingliX <linglix.chen@intel.com>
> > Subject: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> > foxville_nic
> >
> > From: ChenLingli <linglix.chen@intel.com>
> >
> > updated the rx-offloads for foxville_nic
> >
> > Signed-off-by: ChenLingli <linglix.chen@intel.com>
> > ---
> >  tests/TestSuite_pmdrssreta.py | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_pmdrssreta.py
> > b/tests/TestSuite_pmdrssreta.py index
> > 4dd3a5a5..09dd2f55 100644
> > --- a/tests/TestSuite_pmdrssreta.py
> > +++ b/tests/TestSuite_pmdrssreta.py
> > @@ -215,8 +215,12 @@ class TestPmdrssreta(TestCase):
> >                  self.pmdout.start_testpmd(
> >                      "all", "--rxq=%d --txq=%d
> > --rx-offloads=0x00080000 " % (queue, queue), socket=self.ports_socket)
> >              else:
> > -                self.pmdout.start_testpmd(
> > -                    "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> > offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
> > +                if self.nic == 'foxville':
> > +                    self.pmdout.start_testpmd(
> > +                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> > offloads=0x00032a0f" % (queue, queue), socket=self.ports_socket)
> 
> What does the offload mean ?
> 

offloads=0x80000 is a feature added later, the igc pmd did not do relevant adaptation.
It's DPDK bug, please reject this patch.

> > +                else:
> > +                    self.pmdout.start_testpmd(
> > +                        "all", "--mbcache=128 --rxq=%d --txq=%d
> > + --rx-offloads=0x00080000" % (queue, queue),
> > + socket=self.ports_socket)
> >
> >              for iptype, rsstype in list(iptypes.items()):
> >                  self.dut.send_expect("set verbose 8", "testpmd> ")
> > --
> > 2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-22  8:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 17:44 [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic Chen Lingli
2021-03-05  9:49 ` Chen, LingliX
2021-03-10  6:02 ` Tu, Lijuan
2021-03-22  8:40   ` Chen, BoX C

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git